Source/bindings/scripts/generate_global_constructors.py - Issue 1101583003: compositor-worker: Restrict the global interface in CompositorWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/generate_global_constructors.py

Issue 1101583003: compositor-worker: Restrict the global interface in CompositorWorker. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: tot-merge Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt ('k') | Source/core/dom/CompositorProxy.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/generate_global_constructors.py

diff --git a/Source/bindings/scripts/generate_global_constructors.py b/Source/bindings/scripts/generate_global_constructors.py

index 3c709698f9d6955d86cf87b42d1337120ca1b96a..5ad7ff664b51706f180f076f4b88c0789551df4b 100755

--- a/Source/bindings/scripts/generate_global_constructors.py

+++ b/Source/bindings/scripts/generate_global_constructors.py

@@ -24,6 +24,8 @@ import cPickle as pickle

import re

import sys

+from v8_utilities import EXPOSED_EXECUTION_CONTEXT_METHOD

from collections import defaultdict

from utilities import should_generate_impl_file_from_idl, get_file_contents, idl_filename_to_interface_name, read_file_to_list, write_file, get_interface_extended_attributes_from_idl, get_interface_exposed_arguments, is_callback_interface_from_idl

@@ -166,7 +168,7 @@ def main():

record_global_constructors(idl_filename)

# Check for [Exposed] / [Global] mismatch.

- known_global_names = frozenset(itertools.chain.from_iterable(interface_name_to_global_names.values()))

+ known_global_names = EXPOSED_EXECUTION_CONTEXT_METHOD.keys()

exposed_global_names = frozenset(global_name_to_constructors)

if not exposed_global_names.issubset(known_global_names):

unknown_global_names = exposed_global_names.difference(known_global_names)