compositor-worker: Restrict the global interface in CompositorWorker.

LayoutTests/resources/js-test.js

 // js-test now supports lazily printing test results which dumps all test
 // results once at the end of the test instead of building them up. To enable
 // this option, call setPrintTestResultsLazily() before running any tests.
 var _lazyTestResults; // Set by setPrintTestResultsLazily().
 
 // svg/dynamic-updates tests set enablePixelTesting=true, as we want to dump text + pixel results
 if (self.testRunner) {
     if (self.enablePixelTesting)
         testRunner.dumpAsTextWithPixelResults();
     else
@@ skipping 793 matching lines @@
             var span = document.createElement("span");
             span.innerHTML = msg + '<br />';
             consoleElement.appendChild(span);
         });
     }
 
     if (self.jsTestIsAsync && self.testRunner)
         testRunner.notifyDone();
 }
 
-function startWorker(testScriptURL, shared)
+function startWorker(testScriptURL, workerType)
 {
+    var shared = (workerType == 'shared' || (typeof workerType == 'boolean' && workerType));

[haraken, 2015/04/22 11:07:28]

What is the 'typeof workerType == 'boolean' && workerType' check for?

[kinuko, 2015/04/22 14:18:07]

Can we just update all startWorker() for shared worker to take string? (I
guess/hope there're not too many tests for shared worker)

[sadrul, 2015/04/22 22:17:19]

Done! (there was certainly way less than I feared)

+    var compositor = workerType == 'compositor';
     self.jsTestIsAsync = true;
     debug('Starting worker: ' + testScriptURL);
-    var worker = shared ? new SharedWorker(testScriptURL, "Shared Worker") : new Worker(testScriptURL);
+    var worker = shared ? new SharedWorker(testScriptURL, "Shared Worker") : compositor ? new CompositorWorker(testScriptURL) : new Worker(testScriptURL);

[haraken, 2015/04/22 11:07:28]

Can we clean up the code a bit more?

if (...)
  worker = new CompositorWorker();
else if (...)
  worker = new SharedWorker();
else
  worker = new Worker();

[sadrul, 2015/04/22 22:17:19]

Done.

     worker.onmessage = function(event)
     {
         var workerPrefix = "[Worker] ";
         if (event.data.length < 5 || event.data.charAt(4) != ':') {
           debug(workerPrefix + event.data);
           return;
         }
         var code = event.data.substring(0, 4);
         var payload = workerPrefix + event.data.substring(5);
         if (code == "PASS")
@@ skipping 55 matching lines @@
     testPassed = function(msg) {
         workerPort.postMessage('PASS:' + msg);
     };
     finishJSTest = function() {
         workerPort.postMessage('DONE:');
     };
     debug = function(msg) {
         workerPort.postMessage(msg);
     };
 }