Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1101543002: [es6] Class extends may not be a generator function (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Class extends may not be a generator function BUG=v8:4009 LOG=N R=dslomov@chromium.org Committed: https://crrev.com/3f06291b3a40771a88cad76b5948aac54269d869 Cr-Commit-Position: refs/heads/master@{#28016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Lomov (no reviews)
lgtm
5 years, 8 months ago (2015-04-22 12:36:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101543002/1
5 years, 8 months ago (2015-04-22 15:42:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 16:07:38 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 16:07:58 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f06291b3a40771a88cad76b5948aac54269d869
Cr-Commit-Position: refs/heads/master@{#28016}

Powered by Google App Engine
This is Rietveld 408576698