mac: Weakly link against the CoreBluetooth framework.

mac: Weakly link against the CoreBluetooth framework.

In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously,
it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX
10.10, the top level CoreBluetooth framework must be weakly linked.

BUG=463170
Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8
Cr-Commit-Position: refs/heads/master@{#326705}

[erikchen, 2015-04-22 01:53:46]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2015-04-22 01:53:47]

rsesek: Please review.

[erikchen, 2015-04-22 02:08:15]

On 2015/04/22 01:53:47, erikchen wrote:
> rsesek: Please review.

aside: I also need to make this modification to chrome_tests_unit.gypi, and a
couple of other gypi files. I'm surprised that this wasn't pulled in from
build/common.gypi. Will need to investigate.

[erikchen, 2015-04-23 20:55:03]

Patchset #2 (id:20001) has been deleted

[erikchen, 2015-04-23 21:23:04]

Patchset #1 (id:1) has been deleted

[erikchen, 2015-04-23 21:23:09]

Patchset #1 (id:40001) has been deleted

[erikchen, 2015-04-23 21:53:27]

rsesek: Please review.

[Robert Sesek, 2015-04-23 22:22:26]

LGTM

https://codereview.chromium.org/1101513003/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1101513003/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:164: ]
nit: add a trailing comma

[erikchen, 2015-04-23 22:27:45]

https://codereview.chromium.org/1101513003/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth.gyp (right):

https://codereview.chromium.org/1101513003/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth.gyp:164: ]
On 2015/04/23 22:22:26, Robert Sesek wrote:
> nit: add a trailing comma

Done.

[erikchen, 2015-04-23 22:28:03]

erikchen@chromium.org changed reviewers:
+ keybuk@chromium.org

[erikchen, 2015-04-23 22:28:04]

keybuk: Please review.

[keybuk, 2015-04-23 22:29:26]

On 2015/04/23 22:28:04, erikchen wrote:
> keybuk: Please review.

lgtm without understanding

[erikchen, 2015-04-23 22:29:39]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-04-23 22:29:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1101513003/#ps80001
(title: "Comments from rsesek.")

[commit-bot: I haz the power, 2015-04-23 22:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1101513003/80001

[commit-bot: I haz the power, 2015-04-24 00:41:58]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2015-04-24 00:42:55]

Patchset 2 (id:??) landed as
https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8
Cr-Commit-Position: refs/heads/master@{#326705}

[erikchen, 2015-04-24 00:54:37]

A revert of this CL (patchset #2 id:80001) has been created in
https://codereview.chromium.org/1065453003/ by erikchen@chromium.org.

The reason for reverting is: The GN file wasn't formatted correctly.

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds....

[Dirk Pranke, 2015-04-24 00:54:45]

Looks like this broke the Mac GN build:

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20(dbg)/builds/8764

device/BUILD.gn needs to include //build/config/mac/mac_sdk.gni ,  I think.

[Dirk Pranke, 2015-04-24 01:06:44]

A revert of this CL (patchset #2 id:80001) has been created in
https://codereview.chromium.org/1098123004/ by dpranke@chromium.org.

The reason for reverting is: Looks like this broke the Mac GN build:

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20(dbg)/builds/8764

device/BUILD.gn needs to include //build/config/mac/mac_sdk.gni ,  I think..