Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(120)

Issue 11015008: Fix cctests using Sockets to be able to run in parallel (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix cctests using Sockets to be able to run in parallel BUG=v8:945 Committed: https://code.google.com/p/v8/source/detail?r=12636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M test/cctest/cctest.h View 2 chunks +8 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-sockets.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
This is the approach you suggested. Please take a look.
5 years, 2 months ago (2012-10-01 08:48:59 UTC) #1
Michael Starzinger
5 years, 2 months ago (2012-10-01 09:35:35 UTC) #2
LGTM.

As discussed offline, there would be a possible way to get a free port from the
OS (see comment on linked issue). But that would require us to add another
function to our platform abstraction layer and implement it on all platforms
just for the sake of testing. So we should stick with this simple approach.

Powered by Google App Engine
This is Rietveld 0eb02b776