Issue 11015008: Fix cctests using Sockets to be able to run in parallel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11015008: Fix cctests using Sockets to be able to run in parallel (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix cctests using Sockets to be able to run in parallel BUG=v8:945 Committed: https://code.google.com/p/v8/source/detail?r=12636

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -15 lines)			Patch
M	test/cctest/cctest.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.status	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-sockets.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

This is the approach you suggested. Please take a look.

8 years, 2 months ago (2012-10-01 08:48:59 UTC) #1

Michael Starzinger

8 years, 2 months ago (2012-10-01 09:35:35 UTC) #2

LGTM.

As discussed offline, there would be a possible way to get a free port from the
OS (see comment on linked issue). But that would require us to add another
function to our platform abstraction layer and implement it on all platforms
just for the sake of testing. So we should stick with this simple approach.

Expand Messages | Collapse Messages