Chromium Code Reviews| Index: src/compiler/js-type-feedback.cc |
| diff --git a/src/compiler/js-type-feedback.cc b/src/compiler/js-type-feedback.cc |
| index d93dc5c11f3f38aa4b6fe71a0b541003058e3a81..a2ffa0bfa7993400ea79391d730610c984985c54 100644 |
| --- a/src/compiler/js-type-feedback.cc |
| +++ b/src/compiler/js-type-feedback.cc |
| @@ -14,6 +14,7 @@ |
| #include "src/compiler/common-operator.h" |
| #include "src/compiler/node-aux-data.h" |
| #include "src/compiler/node-matchers.h" |
| +#include "src/compiler/operator-properties.h" |
|
Michael Starzinger
2015/04/21 13:50:49
nit: Looks like a leftover.
|
| #include "src/compiler/simplified-operator.h" |
| namespace v8 { |
| @@ -22,6 +23,8 @@ namespace compiler { |
| enum LoadOrStore { LOAD, STORE }; |
| +#define EAGER_DEOPT_LOCATIONS_FOR_PROPERTY_ACCESS_ARE_CORRECT false |
| + |
| JSTypeFeedbackTable::JSTypeFeedbackTable(Zone* zone) |
| : map_(TypeFeedbackIdMap::key_compare(), |
| TypeFeedbackIdMap::allocator_type(zone)) {} |
| @@ -140,6 +143,8 @@ Reduction JSTypeFeedbackSpecializer::ReduceJSLoadNamed(Node* node) { |
| DCHECK(node->opcode() == IrOpcode::kJSLoadNamed); |
| // TODO(turbofan): type feedback currently requires deoptimization. |
| if (!FLAG_turbo_deoptimization) return NoChange(); |
| + // TODO(titzer): deopt locations are wrong for property accesses |
| + if (!EAGER_DEOPT_LOCATIONS_FOR_PROPERTY_ACCESS_ARE_CORRECT) return NoChange(); |
| // TODO(turbofan): handle vector-based type feedback. |
| TypeFeedbackId id = js_type_feedback_->find(node); |
| @@ -192,6 +197,8 @@ Reduction JSTypeFeedbackSpecializer::ReduceJSStoreNamed(Node* node) { |
| DCHECK(node->opcode() == IrOpcode::kJSStoreNamed); |
| // TODO(turbofan): type feedback currently requires deoptimization. |
| if (!FLAG_turbo_deoptimization) return NoChange(); |
| + // TODO(titzer): deopt locations are wrong for property accesses |
| + if (!EAGER_DEOPT_LOCATIONS_FOR_PROPERTY_ACCESS_ARE_CORRECT) return NoChange(); |
| TypeFeedbackId id = js_type_feedback_->find(node); |
| if (id.IsNone() || oracle()->StoreIsUninitialized(id)) return NoChange(); |