Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Issue 1101473004: [turbofan] --turbo implies --turbo-type-feedback and disable fast properties. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] --turbo implies --turbo-type-feedback and disable fast properties. Note: can't be landed until LoadProperty => LoadNamed is fixed. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/cfe6249da2269c2fc4a72bd84cfe00497a24e9ae Cr-Commit-Position: refs/heads/master@{#27979}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compiler/js-type-feedback.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 8 months ago (2015-04-21 13:20:43 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1101473004/diff/1/src/compiler/js-type-feedback.cc File src/compiler/js-type-feedback.cc (right): https://codereview.chromium.org/1101473004/diff/1/src/compiler/js-type-feedback.cc#newcode17 src/compiler/js-type-feedback.cc:17: #include "src/compiler/operator-properties.h" nit: Looks like a leftover.
5 years, 8 months ago (2015-04-21 13:50:49 UTC) #2
titzer
On 2015/04/21 13:50:49, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/1101473004/diff/1/src/compiler/js-type-feedback.cc > File src/compiler/js-type-feedback.cc (right): ...
5 years, 8 months ago (2015-04-21 13:53:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101473004/20001
5 years, 8 months ago (2015-04-21 16:23:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 17:05:23 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:10:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cfe6249da2269c2fc4a72bd84cfe00497a24e9ae
Cr-Commit-Position: refs/heads/master@{#27979}

Powered by Google App Engine
This is Rietveld 408576698