Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1101403002: content: Cleanup the dependencies on webkit_gpu target. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, boliu, danakj, darin (slow to review), jamesr, jochen (gone - plz use gerrit), pilgrim_google, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Cleanup the dependencies on webkit_gpu target. renderer and test do not need to depend on it and compositor_impl_android.cc does not use content_provider_in_process.h either. BUG=338338 R=avi@chromium.org Committed: https://crrev.com/92ee1b3492e0b12a24e7641fd37b5ac9ebb4363b Cr-Commit-Position: refs/heads/master@{#326984}

Patch Set 1 #

Total comments: 1

Patch Set 2 : restrict gn too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
In the next one, I will move context_provider_in_process.* and grcontext_for_webgraphicscontext3d.* into content. I felt this ...
5 years, 8 months ago (2015-04-26 02:42:58 UTC) #1
tfarina
https://codereview.chromium.org/1101403002/diff/1/content/content_browser.gypi File content/content_browser.gypi (right): https://codereview.chromium.org/1101403002/diff/1/content/content_browser.gypi#newcode33 content/content_browser.gypi:33: '../webkit/common/gpu/webkit_gpu.gyp:webkit_gpu', I will add this down below (1894) to ...
5 years, 8 months ago (2015-04-26 02:52:55 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-26 05:06:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101403002/20001
5 years, 8 months ago (2015-04-26 12:22:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-26 12:25:13 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-26 12:26:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92ee1b3492e0b12a24e7641fd37b5ac9ebb4363b
Cr-Commit-Position: refs/heads/master@{#326984}

Powered by Google App Engine
This is Rietveld 408576698