Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: runtime/vm/compiler.cc

Issue 11014013: Added slow_assert macro and flag for slow development assertions in the VM. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index d462881fee0e42a6bd6c5c80b6260677ed23481b..7289a7423ad97cf8232ccecea6c9f72574792c18 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -47,6 +47,7 @@ DEFINE_FLAG(int, deoptimization_counter_threshold, 5,
" certain optimizations");
DEFINE_FLAG(bool, use_inlining, true, "Enable call-site inlining");
DEFINE_FLAG(bool, range_analysis, true, "Enable range analysis");
+DEFINE_FLAG(bool, slow_assert, false, "Enable slow assertions");
DECLARE_FLAG(bool, print_flow_graph);
@@ -180,8 +181,6 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
if (FLAG_use_inlining) {
FlowGraphInliner inliner(flow_graph);
inliner.Inline();
- // Verify that the use lists are still valid.
- DEBUG_ASSERT(flow_graph->ValidateUseLists());
}
// Propagate types and eliminate more type tests.
@@ -191,7 +190,7 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
}
// Verify that the use lists are still valid.
- DEBUG_ASSERT(flow_graph->ValidateUseLists());
+ SLOW_ASSERT(flow_graph->ValidateUseLists());
// Propagate sminess from CheckSmi to phis.
optimizer.PropagateSminess();

Powered by Google App Engine
This is Rietveld 408576698