Added slow_assert macro and flag for slow development assertions in the VM.

runtime/vm/compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
+
+#include "vm/assert.h"
 #include "vm/ast_printer.h"
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/disassembler.h"
 #include "vm/exceptions.h"
 #include "vm/flags.h"
 #include "vm/flow_graph.h"
 #include "vm/flow_graph_allocator.h"
@@ skipping 22 matching lines @@
 DEFINE_FLAG(bool, common_subexpression_elimination, true,
     "Do common subexpression elimination.");
 DEFINE_FLAG(bool, loop_invariant_code_motion, true,
     "Do loop invariant code motion.");
 DEFINE_FLAG(bool, propagate_types, true, "Do static type propagation.");
 DEFINE_FLAG(int, deoptimization_counter_threshold, 5,
     "How many times we allow deoptimization before we disallow"
     " certain optimizations");
 DEFINE_FLAG(bool, use_inlining, true, "Enable call-site inlining");
 DEFINE_FLAG(bool, range_analysis, true, "Enable range analysis");
+DEFINE_FLAG(bool, slow_assert, false, "Enable slow assertions");

[Kevin Millikin (Google), 2012/10/01 11:38:26]

Let's spell it "slow_asserts".

[zerny-google, 2012/10/01 11:50:36]

Done.

 DECLARE_FLAG(bool, print_flow_graph);
 
 
 // Compile a function. Should call only if the function has not been compiled.
 //   Arg0: function object.
 DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
   ASSERT(arguments.Count() == kCompileFunctionRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
   ASSERT(!function.HasCode());
   const Error& error = Error::Handle(Compiler::CompileFunction(function));
@@ skipping 113 matching lines @@
         FlowGraphOptimizer optimizer(flow_graph);
         optimizer.ApplyICData();
 
         // Compute the use lists.
         flow_graph->ComputeUseLists();
 
         // Inlining (mutates the flow graph)
         if (FLAG_use_inlining) {
           FlowGraphInliner inliner(flow_graph);
           inliner.Inline();
-          // Verify that the use lists are still valid.
-          DEBUG_ASSERT(flow_graph->ValidateUseLists());
         }
 
         // Propagate types and eliminate more type tests.
         if (FLAG_propagate_types) {
           FlowGraphTypePropagator propagator(flow_graph);
           propagator.PropagateTypes();
         }
 
         // Verify that the use lists are still valid.
-        DEBUG_ASSERT(flow_graph->ValidateUseLists());
+        SLOW_ASSERT(flow_graph->ValidateUseLists());
 
         // Propagate sminess from CheckSmi to phis.
         optimizer.PropagateSminess();
 
         // Do optimizations that depend on the propagated type information.
         optimizer.OptimizeComputations();
 
         // Unbox doubles.
         flow_graph->ComputeUseLists();
         optimizer.SelectRepresentations();
@@ skipping 379 matching lines @@
     result = isolate->object_store()->sticky_error();
     isolate->object_store()->clear_sticky_error();
     isolate->set_long_jump_base(base);
     return result.raw();
   }
   UNREACHABLE();
   return Object::null();
 }
 
 }  // namespace dart