[Sync] Fix passphrase prompt for legacy accounts

[Sync] Fix passphrase prompt for legacy accounts

Make sure that we always include the dashboard reset link in any passphrase
prompt. Also ensure we use the term "sync passphrase" rather than "google
password". Lastly, use the passphrase time if its available.

BUG=481224
Committed: https://crrev.com/ba1691a43a87cf9cba307fdc689c2c19f50bc540
Cr-Commit-Position: refs/heads/master@{#327209}

[Nicolas Zea, 2015-04-25 01:12:41]

zea@chromium.org changed reviewers:
+ maxbogue@chromium.org, nyquist@chromium.org

[Nicolas Zea, 2015-04-25 01:12:42]

+Tommy to review, +Max FYI

[Nicolas Zea, 2015-04-27 23:22:40]

Ping, this is a 43 blocker

[nyquist, 2015-04-28 00:36:33]

This lgtm, feel free to submit as is. The way the CL is now should be good to
merge to M43.

I would be really happy if you'd look into some of those cleanup suggestions in
a follow-up patch though.

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java
(left):

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java:507:
return res.getString(R.string.sync_need_password);
Can this string be deleted now?

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java
(right):

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java:50:
public void onPassphraseEntered(String password, boolean isGaia, boolean
isUpdate);
Is it possible to remove isGaia here and below now?

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java:55:
static final String ARG_IS_GAIA = "is_gaia";
Remove?

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(right):

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:341:
private void displayPasswordDialog(boolean isGaia, boolean isUpdate) {
can isGaia go away here as well? Also; maybe rename to displayPassphraseDialog?

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:347:
private void displayCustomPasswordDialog() {
I think this would be easier to read as displayPassphraseCreationDialog.

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:459:
public void onPassphraseTypeSelected(PassphraseType type) {
Can this argument go away now? If so, there might be some more possible cleanup
work in PassphraseTypeDialogFragment and friends.

[Nicolas Zea, 2015-04-28 00:39:23]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-04-28 00:39:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1101373002/40001

[maxbogue, 2015-04-28 00:40:26]

Overall looks great. I'm not convinced removing all the "password" messaging is
a good idea. Is the idea there that even if we call it a google password in the
instructions (which we do iirc for IMPLICIT and FROZEN_IMPLICIT) we still want
to to call the thing they're entering a passphrase?

Also I'm requesting that you finish the cleanup that you've started (see
comments). It will technically make this CL "bigger" but negative lines are the
best and it will make it easier to see that the right things are happening.

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java
(right):

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java:62:
Fragment target, boolean isGaia, boolean isUpdate) {
Please remove the isGaia and isUpdate arguments from this class and SCF
entirely, as neither is used after this CL.

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java:125:
promptText.setText(accountName
Are we assuming here that the type is CUSTOM_PASSPHRASE? Should we assert that?

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseDialogFragment.java:128:
passphrase.setHint(R.string.sync_enter_custom_passphrase_hint);
This will set the hint for the field to "Passphrase" even for the password
cases. I think this is intentional given your CL description, but I'm unsure
it's the best idea because I believe the instructions use the word "password" in
those cases. Meaning we'd be inconsistent with the terminology on the same
screen.

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(left):

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:472:
if (type == PassphraseType.IMPLICIT_PASSPHRASE) {
I assumed from the code that at some point in time there was a transition flow
where the user would enter their old implicit passphrase and then enter their
new custom one. At this point I'm fairly sure that flow is broken anyways. I
assume now users will just do a dashboard reset and we're abandoning the old way
completely?

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(right):

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:373:
private void handleEncryptWithGaia(final String passphrase) {
This method is now dead. Please remove.

https://codereview.chromium.org/1101373002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:432:
handleEncryptWithCustomPassphrase(passphrase);
isUpdate is always false after this CL. Please remove
handleEncryptWithCustomPassphrase() and configureEncryption() entirely.

[commit-bot: I haz the power, 2015-04-28 01:08:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 01:09:17]

Patchset 3 (id:??) landed as
https://crrev.com/ba1691a43a87cf9cba307fdc689c2c19f50bc540
Cr-Commit-Position: refs/heads/master@{#327209}