Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1101343002: Update {virtual,override} to follow C++11 style in src/fonts. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in src/fonts. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/fonts -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/37a92b44373a6ace53d7f446206e9dc544fff288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M src/fonts/SkFontMgr_fontconfig.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/fonts/SkTestScalerContext.h View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
5 years, 8 months ago (2015-04-24 21:09:45 UTC) #1
mtklein
lgtm
5 years, 8 months ago (2015-04-24 21:19:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101343002/1
5 years, 8 months ago (2015-04-24 21:20:10 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:25:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/37a92b44373a6ace53d7f446206e9dc544fff288

Powered by Google App Engine
This is Rietveld 408576698