GN: Generate phony rules for unique executables.

GN: Generate phony rules for unique executables.

Prior to this CL, if there were multiple targets ina GN build
with the name 'unit_tests', we would not generate a top-level
phony ninja target for them; you would have to specify either
the full path to the output or the label name.

This is confusing for things like 'browser_tests' and 'unit_tests',
where in Chromium we might have multiple targets with that name,
but only one of those is an executable (at least in the default
toolchain).

This CL adds logic to handle that case (so that 'unit_tests' does work).

R=brettw@chromium.org
BUG=480042
Committed: https://crrev.com/ab689a4f50c56521396eeab8deb9f8c6945d3c88
Cr-Commit-Position: refs/heads/master@{#326942}

[brettw, 2015-04-24 23:42:11]

lgtm

https://codereview.chromium.org/1101323005/diff/1/tools/gn/ninja_build_writer.cc
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/1101323005/diff/1/tools/gn/ninja_build_writer...
tools/gn/ninja_build_writer.cc:213: // Look for executables; later we will
generate phony rules
Can you re-wrap this? It seems like a weird place to break

[Dirk Pranke, 2015-04-24 23:50:11]

https://codereview.chromium.org/1101323005/diff/1/tools/gn/ninja_build_writer.cc
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/1101323005/diff/1/tools/gn/ninja_build_writer...
tools/gn/ninja_build_writer.cc:213: // Look for executables; later we will
generate phony rules
On 2015/04/24 23:42:11, brettw wrote:
> Can you re-wrap this? It seems like a weird place to break

Acknowledged.

[Dirk Pranke, 2015-04-24 23:50:14]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-04-24 23:50:15]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1101323005/#ps20001
(title: "reformat")

[commit-bot: I haz the power, 2015-04-24 23:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1101323005/20001

[commit-bot: I haz the power, 2015-04-25 00:29:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-25 00:30:39]

Patchset 2 (id:??) landed as
https://crrev.com/ab689a4f50c56521396eeab8deb9f8c6945d3c88
Cr-Commit-Position: refs/heads/master@{#326942}