Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1101323003: Work on Windows GN tests (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, grt+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work on Windows GN tests CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/2a6477237c15091438aaac54cbf7cafd0be57294 Cr-Commit-Position: refs/heads/master@{#326889}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -32 lines) Patch
M BUILD.gn View 1 2 chunks +3 lines, -2 lines 0 comments Download
A chrome/app_installer/BUILD.gn View 1 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/app_installer/app_installer.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/installer/launcher_support/BUILD.gn View 1 chunk +14 lines, -14 lines 0 comments Download
M extensions/common/BUILD.gn View 2 chunks +7 lines, -5 lines 0 comments Download
A + third_party/omaha/BUILD.gn View 1 chunk +12 lines, -11 lines 0 comments Download
M third_party/omaha/omaha.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 8 months ago (2015-04-24 20:40:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101323003/20001
5 years, 8 months ago (2015-04-24 20:41:19 UTC) #4
scottmg
lgtm
5 years, 8 months ago (2015-04-24 21:01:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101323003/20001
5 years, 8 months ago (2015-04-24 21:06:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 21:51:52 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:54:23 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2a6477237c15091438aaac54cbf7cafd0be57294
Cr-Commit-Position: refs/heads/master@{#326889}

Powered by Google App Engine
This is Rietveld 408576698