Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1101303002: Update mojo sdk to rev e7270700d671fa8e458b4d8c9e47f7bcfb65da0b (Closed)

Created:
5 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 8 months ago
Reviewers:
Hajime Morrita
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev e7270700d671fa8e458b4d8c9e47f7bcfb65da0b This cherry-picks two mojo changes past e7270700, namely: mojo.gni fix: https://chromium.googlesource.com/external/mojo/+/c88997f930c71b7e6748948263c4c01d7e10bc75 generated C++ interface definition fix: https://chromium.googlesource.com/external/mojo/+/6f41dc4d98fc17a447cd48837cc8ff7edf8df465 Finally this CL also adds a default TaskTracker to the chromium mojo environment. BUG= TBR=ben@chromium.org Committed: https://crrev.com/dcab72d3dd89fb0b296bcf7d7f5937cd449183c0 Cr-Commit-Position: refs/heads/master@{#326890}

Patch Set 1 : Straight roll with no modifications #

Patch Set 2 : Cherry-pick mojom.gni change #

Patch Set 3 : Add default TaskTracker to chromium environment; update environment build rules #

Patch Set 4 : Update Android InterfaceTests #

Patch Set 5 : Fix up C++ interface definitions #

Patch Set 6 : Updated C++ bindings fix #

Patch Set 7 : Update content javatests #

Patch Set 8 : Actualy provide a default TaskTracker impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1314 lines, -261 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ServiceRegistryTest.java View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/InterfacesTest.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/BUILD.gn View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
A mojo/environment/default_task_tracker_impl.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A mojo/environment/default_task_tracker_impl.cc View 1 2 3 4 5 6 7 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/environment/environment.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/bindings_serialization.h View 3 chunks +0 lines, -16 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/bindings_serialization.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/map_serialization.h View 5 chunks +19 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/message_header_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_util.h View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_util.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/union_unittest.cc View 2 chunks +296 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/BUILD.gn View 3 chunks +7 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/environment.h View 2 chunks +5 lines, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/lib/default_task_tracker.h View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/lib/default_task_tracker.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/lib/environment.cc View 3 chunks +17 lines, -4 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/lib/scoped_task_tracking.h View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/lib/scoped_task_tracking.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/cpp/environment/task_tracker.h View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/dart/README View 1 chunk +0 lines, -17 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/README.md View 1 chunk +126 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/application.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/decoder.go View 6 chunks +18 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/bindings/message.go View 3 chunks +42 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/core.go View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/mojo_types.go View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/shared_buffer.go View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_unions.mojom View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 1 chunk +89 lines, -44 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 3 4 5 4 chunks +32 lines, -56 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 chunk +28 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 4 chunks +25 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl View 5 chunks +9 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/interface.tmpl View 4 chunks +28 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/struct.tmpl View 5 chunks +11 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +15 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 1 10 chunks +94 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom_bindings_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 2 chunks +14 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator_unittest.py View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_analyze.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Rockot(use gerrit already)
Morrita, could you please take a look at my changes adding a default TaskTracker?
5 years, 8 months ago (2015-04-24 16:39:48 UTC) #2
Hajime Morrita
lgtm. Thanks for taking care of it!
5 years, 8 months ago (2015-04-24 17:05:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101303002/140001
5 years, 8 months ago (2015-04-24 21:15:36 UTC) #6
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 8 months ago (2015-04-24 21:53:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:54:26 UTC) #8
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/dcab72d3dd89fb0b296bcf7d7f5937cd449183c0
Cr-Commit-Position: refs/heads/master@{#326890}

Powered by Google App Engine
This is Rietveld 408576698