Issue 11013014: Convert InstancePrivate to IDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11013014: Convert InstancePrivate to IDL. (Closed)

Created:
8 years, 2 months ago by brettw

Modified:
8 years, 2 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert InstancePrivate to IDL. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160190

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -35 lines)			Patch
A +	ppapi/api/private/ppp_instance_private.idl	View	1	3 chunks	+6 lines, -23 lines	0 comments	Download
M	ppapi/c/private/ppp_instance_private.h	View		2 chunks	+16 lines, -9 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	1 2 3	7 chunks	+24 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppp_instance_private_proxy.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yzshen1

https://codereview.chromium.org/11013014/diff/1/ppapi/api/private/ppp_instance_private.idl File ppapi/api/private/ppp_instance_private.idl (right): https://codereview.chromium.org/11013014/diff/1/ppapi/api/private/ppp_instance_private.idl#newcode12 ppapi/api/private/ppp_instance_private.idl:12: M22 = 0.1 Please change it to the first ...

8 years, 2 months ago (2012-10-02 21:14:43 UTC) #2

brettw

I changed the interface to 18 which was the last time this was changed. I ...

8 years, 2 months ago (2012-10-02 21:28:38 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 11013014: Convert InstancePrivate to IDL. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages