Issue 11013007: Test runner: Send SVN revision instead of git commit hash in work packet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11013007: Test runner: Send SVN revision instead of git commit hash in work packet (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Test runner: Send SVN revision instead of git commit hash in work packet Committed: https://code.google.com/p/v8/source/detail?r=12635

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
	M	tools/testrunner/network/network_execution.py	View		2 chunks	+8 lines, -2 lines	2 comments	Download
	M	tools/testrunner/server/work_handler.py	View		1 chunk	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://chromiumcodereview.appspot.com/11013007/diff/1/tools/testrunner/network/network_execution.py File tools/testrunner/network/network_execution.py (right): https://chromiumcodereview.appspot.com/11013007/diff/1/tools/testrunner/network/network_execution.py#newcode75 tools/testrunner/network/network_execution.py:75: " | sed -e 's/.*@//'" % # Strip ...

8 years, 2 months ago (2012-10-01 08:59:22 UTC) #2

Jakob Kummerow

8 years, 2 months ago (2012-10-01 09:05:08 UTC) #3

Landing.

https://chromiumcodereview.appspot.com/11013007/diff/1/tools/testrunner/netwo...
File tools/testrunner/network/network_execution.py (right):

https://chromiumcodereview.appspot.com/11013007/diff/1/tools/testrunner/netwo...
tools/testrunner/network/network_execution.py:75: " | sed -e 's/.*@//'" % #
Strip away "repository@".
On 2012/10/01 08:59:22, Michael Starzinger wrote:
> You could indent the more to match it up with the others.

Done.

Expand Messages | Collapse Messages