Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1101273002: [turbofan] Ignore dead cached nodes in the JSGraph. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ignore dead cached nodes in the JSGraph. BUG=chromium:480807 LOG=n R=jarin@chromium.org Committed: https://crrev.com/4f9bc2d1c352136713b6122c1e2ba54cb552d9ae Cr-Commit-Position: refs/heads/master@{#28041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M src/compiler/js-graph.cc View 2 chunks +11 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-480807.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-24 09:49:03 UTC) #1
Benedikt Meurer
Hey Jaro, Michi, This is the fix suggested by Michi. Please take a look. Thanks, ...
5 years, 8 months ago (2015-04-24 09:49:47 UTC) #3
Jarin
closing my eyes, typing lgtm...
5 years, 8 months ago (2015-04-24 10:24:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101273002/1
5 years, 8 months ago (2015-04-24 10:49:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 10:51:53 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 10:52:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f9bc2d1c352136713b6122c1e2ba54cb552d9ae
Cr-Commit-Position: refs/heads/master@{#28041}

Powered by Google App Engine
This is Rietveld 408576698