Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: Source/modules/credentialmanager/NavigatorCredentials.cpp

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/NavigatorCredentials.cpp
diff --git a/Source/modules/credentialmanager/NavigatorCredentials.cpp b/Source/modules/credentialmanager/NavigatorCredentials.cpp
index 1138ce0e25b83a80f5f95198b6e6004d90ac4bd6..304f5c8819f6d97c38b9e6eb78a1533512904556 100644
--- a/Source/modules/credentialmanager/NavigatorCredentials.cpp
+++ b/Source/modules/credentialmanager/NavigatorCredentials.cpp
@@ -18,14 +18,16 @@ NavigatorCredentials::NavigatorCredentials(Navigator& navigator)
{
}
-DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(NavigatorCredentials);
+NavigatorCredentials::~NavigatorCredentials()
+{
+}
NavigatorCredentials& NavigatorCredentials::from(Navigator& navigator)
{
- NavigatorCredentials* supplement = static_cast<NavigatorCredentials*>(WillBeHeapSupplement<Navigator>::from(navigator, supplementName()));
+ NavigatorCredentials* supplement = static_cast<NavigatorCredentials*>(HeapSupplement<Navigator>::from(navigator, supplementName()));
if (!supplement) {
supplement = new NavigatorCredentials(navigator);
- provideTo(navigator, supplementName(), adoptPtrWillBeNoop(supplement));
+ provideTo(navigator, supplementName(), supplement);
}
return *supplement;
}
@@ -50,7 +52,7 @@ CredentialsContainer* NavigatorCredentials::credentials()
DEFINE_TRACE(NavigatorCredentials)
{
visitor->trace(m_credentialsContainer);
- WillBeHeapSupplement<Navigator>::trace(visitor);
+ HeapSupplement<Navigator>::trace(visitor);
DOMWindowProperty::trace(visitor);
}
« no previous file with comments | « Source/modules/credentialmanager/NavigatorCredentials.h ('k') | Source/modules/donottrack/NavigatorDoNotTrack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698