Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: Source/modules/webmidi/NavigatorWebMIDI.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/NavigatorWebMIDI.h
diff --git a/Source/modules/webmidi/NavigatorWebMIDI.h b/Source/modules/webmidi/NavigatorWebMIDI.h
index 2f245a4928a806f61923573a21ea1c0ca9941942..8dd4105ebd40784dc6fde0a97d7caf6405d51825 100644
--- a/Source/modules/webmidi/NavigatorWebMIDI.h
+++ b/Source/modules/webmidi/NavigatorWebMIDI.h
@@ -41,11 +41,11 @@ namespace blink {
class Navigator;
-class NavigatorWebMIDI final : public NoBaseWillBeGarbageCollected<NavigatorWebMIDI>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorWebMIDI);
- DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(NavigatorWebMIDI);
+class NavigatorWebMIDI final : public GarbageCollectedFinalized<NavigatorWebMIDI>, public HeapSupplement<Navigator>, DOMWindowProperty {
+ USING_GARBAGE_COLLECTED_MIXIN(NavigatorWebMIDI);
public:
static NavigatorWebMIDI& from(Navigator&);
+ virtual ~NavigatorWebMIDI();
static ScriptPromise requestMIDIAccess(ScriptState*, Navigator&, const MIDIOptions&);
ScriptPromise requestMIDIAccess(ScriptState*, const MIDIOptions&);
@@ -53,7 +53,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- NavigatorWebMIDI(LocalFrame*);
+ explicit NavigatorWebMIDI(LocalFrame*);
static const char* supplementName();
};

Powered by Google App Engine
This is Rietveld 408576698