Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: Source/modules/netinfo/NavigatorNetworkInformation.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/netinfo/NavigatorNetworkInformation.h
diff --git a/Source/modules/netinfo/NavigatorNetworkInformation.h b/Source/modules/netinfo/NavigatorNetworkInformation.h
index e4e15ade73673df6911e365d945b4a7009b66f49..ae166c3ec305a00fcc44d272f8b54287c975009c 100644
--- a/Source/modules/netinfo/NavigatorNetworkInformation.h
+++ b/Source/modules/netinfo/NavigatorNetworkInformation.h
@@ -13,16 +13,13 @@ namespace blink {
class Navigator;
class NetworkInformation;
-class NavigatorNetworkInformation final
- : public NoBaseWillBeGarbageCollected<NavigatorNetworkInformation>
- , public WillBeHeapSupplement<Navigator>
- , DOMWindowProperty {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorNetworkInformation);
- DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(NavigatorNetworkInformation);
+class NavigatorNetworkInformation final : public GarbageCollectedFinalized<NavigatorNetworkInformation>, public HeapSupplement<Navigator>, DOMWindowProperty {
+ USING_GARBAGE_COLLECTED_MIXIN(NavigatorNetworkInformation);
public:
static NavigatorNetworkInformation& from(Navigator&);
static NavigatorNetworkInformation* toNavigatorNetworkInformation(Navigator&);
- static const char* supplementName();
+
+ virtual ~NavigatorNetworkInformation();
static NetworkInformation* connection(Navigator&);
@@ -32,7 +29,9 @@ private:
explicit NavigatorNetworkInformation(Navigator&);
NetworkInformation* connection();
- PersistentWillBeMember<NetworkInformation> m_connection;
+ static const char* supplementName();
+
+ Member<NetworkInformation> m_connection;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698