Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: Source/modules/geolocation/NavigatorGeolocation.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/NavigatorGeolocation.h
diff --git a/Source/modules/geolocation/NavigatorGeolocation.h b/Source/modules/geolocation/NavigatorGeolocation.h
index b4df7674d1784eb583eeda37406d79290ff57fd4..dc5b2a86ed2b4228f4fa0d3c1f832dd64a7730d8 100644
--- a/Source/modules/geolocation/NavigatorGeolocation.h
+++ b/Source/modules/geolocation/NavigatorGeolocation.h
@@ -30,11 +30,11 @@ class LocalFrame;
class Geolocation;
class Navigator;
-class NavigatorGeolocation final : public NoBaseWillBeGarbageCollected<NavigatorGeolocation>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorGeolocation);
- DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(NavigatorGeolocation);
+class NavigatorGeolocation final : public GarbageCollectedFinalized<NavigatorGeolocation>, public HeapSupplement<Navigator>, DOMWindowProperty {
+ USING_GARBAGE_COLLECTED_MIXIN(NavigatorGeolocation);
public:
static NavigatorGeolocation& from(Navigator&);
+ virtual ~NavigatorGeolocation();
static Geolocation* geolocation(Navigator&);
Geolocation* geolocation();
@@ -42,10 +42,11 @@ public:
DECLARE_TRACE();
private:
- NavigatorGeolocation(LocalFrame*);
+ explicit NavigatorGeolocation(LocalFrame*);
+
static const char* supplementName();
- PersistentWillBeMember<Geolocation> m_geolocation;
+ Member<Geolocation> m_geolocation;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698