Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Unified Diff: Source/modules/gamepad/NavigatorGamepad.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/gamepad/NavigatorGamepad.h
diff --git a/Source/modules/gamepad/NavigatorGamepad.h b/Source/modules/gamepad/NavigatorGamepad.h
index 68eb8a0629f7e73484396a41843b88026cdc0c7a..f7193379a7d67b608db60918f8a1352f97951fbd 100644
--- a/Source/modules/gamepad/NavigatorGamepad.h
+++ b/Source/modules/gamepad/NavigatorGamepad.h
@@ -42,8 +42,8 @@ class Gamepad;
class GamepadList;
class Navigator;
-class MODULES_EXPORT NavigatorGamepad final : public NoBaseWillBeGarbageCollectedFinalized<NavigatorGamepad>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty, public PlatformEventController, public DOMWindowLifecycleObserver {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorGamepad);
+class MODULES_EXPORT NavigatorGamepad final : public GarbageCollectedFinalized<NavigatorGamepad>, public HeapSupplement<Navigator>, DOMWindowProperty, public PlatformEventController, public DOMWindowLifecycleObserver {
+ USING_GARBAGE_COLLECTED_MIXIN(NavigatorGamepad);
public:
static NavigatorGamepad* from(Document&);
static NavigatorGamepad& from(Navigator&);
@@ -81,8 +81,8 @@ private:
virtual void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) override;
virtual void didRemoveAllEventListeners(LocalDOMWindow*) override;
- PersistentWillBeMember<GamepadList> m_gamepads;
- PersistentHeapDequeWillBeHeapDeque<Member<Gamepad>> m_pendingEvents;
+ Member<GamepadList> m_gamepads;
+ HeapDeque<Member<Gamepad>> m_pendingEvents;
AsyncMethodRunner<NavigatorGamepad> m_dispatchOneEventRunner;
};

Powered by Google App Engine
This is Rietveld 408576698