Source/modules/donottrack/NavigatorDoNotTrack.h - Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/donottrack/NavigatorDoNotTrack.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/beacon/NavigatorBeacon.cpp ('K') | « Source/modules/credentialmanager/NavigatorCredentials.cpp ('k') | Source/modules/donottrack/NavigatorDoNotTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/donottrack/NavigatorDoNotTrack.h

diff --git a/Source/modules/donottrack/NavigatorDoNotTrack.h b/Source/modules/donottrack/NavigatorDoNotTrack.h

index 30b631b32b28c8e3bb84593ce27f6e2b99e21e03..7f730102e86465f7ea88e28deabe6bdcfed86830 100644

--- a/Source/modules/donottrack/NavigatorDoNotTrack.h

+++ b/Source/modules/donottrack/NavigatorDoNotTrack.h

@@ -41,11 +41,11 @@ namespace blink {

class LocalFrame;

class Navigator;

-class NavigatorDoNotTrack final : public NoBaseWillBeGarbageCollected<NavigatorDoNotTrack>, public WillBeHeapSupplement<Navigator>, public DOMWindowProperty {

- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorDoNotTrack);

- DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(NavigatorDoNotTrack);

+class NavigatorDoNotTrack final : public GarbageCollectedFinalized<NavigatorDoNotTrack>, public HeapSupplement<Navigator>, DOMWindowProperty {

+ USING_GARBAGE_COLLECTED_MIXIN(NavigatorDoNotTrack);

public:

static NavigatorDoNotTrack& from(Navigator&);

+ virtual ~NavigatorDoNotTrack();

static String doNotTrack(Navigator&);