Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: Source/modules/beacon/NavigatorBeacon.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/beacon/NavigatorBeacon.h
diff --git a/Source/modules/beacon/NavigatorBeacon.h b/Source/modules/beacon/NavigatorBeacon.h
index 989f35497b10f067f92c73fd0df8ff5fe46492c0..5f11250d3ac6e6bb82eef049c0ab8f4e3e0807a0 100644
--- a/Source/modules/beacon/NavigatorBeacon.h
+++ b/Source/modules/beacon/NavigatorBeacon.h
@@ -5,6 +5,7 @@
#ifndef NavigatorBeacon_h
#define NavigatorBeacon_h
+#include "core/frame/LocalFrameLifecycleObserver.h"
#include "core/frame/Navigator.h"
#include "platform/Supplementable.h"
#include "platform/heap/Handle.h"
@@ -17,10 +18,11 @@ class ExecutionContext;
class KURL;
class ArrayBufferViewOrBlobOrStringOrFormData;
-class NavigatorBeacon final : public NoBaseWillBeGarbageCollected<NavigatorBeacon>, public WillBeHeapSupplement<Navigator> {
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorBeacon);
+class NavigatorBeacon final : public GarbageCollectedFinalized<NavigatorBeacon>, public LocalFrameLifecycleObserver, public HeapSupplement<Navigator> {
+ USING_GARBAGE_COLLECTED_MIXIN(NavigatorBeacon);
public:
static NavigatorBeacon& from(Navigator&);
+ virtual ~NavigatorBeacon();
static bool sendBeacon(ExecutionContext*, Navigator&, const String&, const ArrayBufferViewOrBlobOrStringOrFormData&, ExceptionState&);
@@ -36,7 +38,6 @@ private:
bool beaconResult(ExecutionContext*, bool allowed, int sentBytes);
int m_transmittedBytes;
- Navigator& m_navigator;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698