Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: Source/core/frame/DOMWindowProperty.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.h » ('j') | Source/modules/beacon/NavigatorBeacon.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindowProperty.h
diff --git a/Source/core/frame/DOMWindowProperty.h b/Source/core/frame/DOMWindowProperty.h
index 5ec31f820e083fd5d0fc0d197a639b1df45dd1e8..dcb12e57328543041f093eaca020f58fbd9ebd59 100644
--- a/Source/core/frame/DOMWindowProperty.h
+++ b/Source/core/frame/DOMWindowProperty.h
@@ -46,6 +46,8 @@ public:
DECLARE_VIRTUAL_TRACE();
protected:
+ // TODO(Oilpan): when ~DOMWindowProperty is removed, check classes that derive
+ // from it. Several will then be able to derive from GarbageCollected<> instead.
#if !ENABLE(OILPAN)
virtual ~DOMWindowProperty();
#endif
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.h » ('j') | Source/modules/beacon/NavigatorBeacon.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698