Source/core/frame/DOMWindowProperty.h - Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindowProperty.h

Issue 1101263003: Oilpan: have Navigator and its supplements be on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make NavigatorBeacon a frame observer instead Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/DOMWindowProperty.h

diff --git a/Source/core/frame/DOMWindowProperty.h b/Source/core/frame/DOMWindowProperty.h

index 5ec31f820e083fd5d0fc0d197a639b1df45dd1e8..dcb12e57328543041f093eaca020f58fbd9ebd59 100644

--- a/Source/core/frame/DOMWindowProperty.h

+++ b/Source/core/frame/DOMWindowProperty.h

@@ -46,6 +46,8 @@ public:

DECLARE_VIRTUAL_TRACE();

protected:

+ // TODO(Oilpan): when ~DOMWindowProperty is removed, check classes that derive

+ // from it. Several will then be able to derive from GarbageCollected<> instead.

#if !ENABLE(OILPAN)

virtual ~DOMWindowProperty();

#endif