Oilpan: have Navigator and its supplements be on the heap by default.

Source/modules/beacon/NavigatorBeacon.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NavigatorBeacon_h
 #define NavigatorBeacon_h
 
 #include "core/frame/Navigator.h"
 #include "platform/Supplementable.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class Blob;
 class ExceptionState;
 class ExecutionContext;
 class KURL;
 class ArrayBufferViewOrBlobOrStringOrFormData;
 
-class NavigatorBeacon final : public NoBaseWillBeGarbageCollected<NavigatorBeacon>, public WillBeHeapSupplement<Navigator> {
-    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorBeacon);
+class NavigatorBeacon final : public GarbageCollected<NavigatorBeacon>, public HeapSupplement<Navigator> {
+    USING_GARBAGE_COLLECTED_MIXIN(NavigatorBeacon);
 public:
     static NavigatorBeacon& from(Navigator&);
 
     static bool sendBeacon(ExecutionContext*, Navigator&, const String&, const ArrayBufferViewOrBlobOrStringOrFormData&, ExceptionState&);
 
     DECLARE_VIRTUAL_TRACE();
 
 private:
     explicit NavigatorBeacon(Navigator&);
 
     static const char* supplementName();
 
     bool canSendBeacon(ExecutionContext*, const KURL&, ExceptionState&);
     int maxAllowance() const;
     bool beaconResult(ExecutionContext*, bool allowed, int sentBytes);
 
     int m_transmittedBytes;
     Navigator& m_navigator;

[haraken, 2015/04/24 15:32:35]

This should be Member<Navigator>.

yutak@: I think we should improve the GC plugin so that it can catch references
to on-heap objects. Currnetly the plugin can catch only raw pointers to on-heap
objects.

BTW, it seems strange that NavigatorXXX needs to hold a reference to XXX. Is it
a mis-design?

[sof, 2015/04/24 21:25:08]

A convenience, Navigator would live as long as the supplement. Turned
NavigatorBeacon into a LocalFrameLifecycleObserver instead.

 };
 
 } // namespace blink
 
 #endif // NavigatorBeacon_h