Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: pkg/analyzer/lib/src/plugin/engine_plugin.dart

Issue 1101213002: Revert breaking change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/analyzer/lib/plugin/task.dart ('k') | pkg/analyzer/pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.plugin.engine_plugin; 5 library analyzer.src.plugin.engine_plugin;
6 6
7 import 'package:analyzer/plugin/plugin.dart';
7 import 'package:analyzer/plugin/task.dart'; 8 import 'package:analyzer/plugin/task.dart';
8 import 'package:analyzer/src/task/dart.dart'; 9 import 'package:analyzer/src/task/dart.dart';
9 import 'package:analyzer/src/task/general.dart'; 10 import 'package:analyzer/src/task/general.dart';
10 import 'package:analyzer/task/model.dart'; 11 import 'package:analyzer/task/model.dart';
11 import 'package:plugin/plugin.dart';
12 12
13 /** 13 /**
14 * A plugin that defines the extension points and extensions that are inherently 14 * A plugin that defines the extension points and extensions that are inherently
15 * defined by the analysis engine. 15 * defined by the analysis engine.
16 */ 16 */
17 class EnginePlugin implements Plugin { 17 class EnginePlugin implements Plugin {
18 /** 18 /**
19 * The simple identifier of the extension point that allows plugins to 19 * The simple identifier of the extension point that allows plugins to
20 * register new analysis tasks with the analysis engine. 20 * register new analysis tasks with the analysis engine.
21 */ 21 */
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 * Validate the given extension by throwing an [ExtensionError] if it is not a 91 * Validate the given extension by throwing an [ExtensionError] if it is not a
92 * valid domain. 92 * valid domain.
93 */ 93 */
94 void _validateTaskExtension(Object extension) { 94 void _validateTaskExtension(Object extension) {
95 if (extension is! TaskDescriptor) { 95 if (extension is! TaskDescriptor) {
96 String id = taskExtensionPoint.uniqueIdentifier; 96 String id = taskExtensionPoint.uniqueIdentifier;
97 throw new ExtensionError('Extensions to $id must be a TaskDescriptor'); 97 throw new ExtensionError('Extensions to $id must be a TaskDescriptor');
98 } 98 }
99 } 99 }
100 } 100 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/plugin/task.dart ('k') | pkg/analyzer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698