Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: net/cookies/canonical_cookie.cc

Issue 1101173004: Switch remaining functions from SchemeIsSecure() to SchemeIsCryptographic(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/sdch_manager.cc ('k') | net/http/http_auth_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/canonical_cookie.cc
diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc
index 5932c23a8818ef4cf6e0f60983f9694d246c8b78..df97780fe4547af6b120eaf37b7353d63f4acb70 100644
--- a/net/cookies/canonical_cookie.cc
+++ b/net/cookies/canonical_cookie.cc
@@ -187,7 +187,7 @@ std::string CanonicalCookie::GetCookieSourceFromURL(const GURL& url) {
url::Replacements<char> replacements;
replacements.ClearPort();
- if (url.SchemeIsSecure())
+ if (url.SchemeIsCryptographic())
replacements.SetScheme("http", url::Component(0, 4));
return url.GetOrigin().ReplaceComponents(replacements).spec();
@@ -395,7 +395,7 @@ bool CanonicalCookie::IncludeForRequestURL(const GURL& url,
return false;
// Secure cookies should not be included in requests for URLs with an
// insecure scheme.
- if (IsSecure() && !url.SchemeIsSecure())
+ if (IsSecure() && !url.SchemeIsCryptographic())
palmer 2015/04/24 19:55:11 This is a semantic change. It might be a change fr
return false;
// Don't include cookies for requests that don't apply to the cookie domain.
if (!IsDomainMatch(url.host()))
« no previous file with comments | « net/base/sdch_manager.cc ('k') | net/http/http_auth_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698