components/error_page/renderer/net_error_helper_core.cc - Issue 1101173004: Switch remaining functions from SchemeIsSecure() to SchemeIsCryptographic().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/renderer/net_error_helper_core.cc

Issue 1101173004: Switch remaining functions from SchemeIsSecure() to SchemeIsCryptographic(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | net/cookies/canonical_cookie.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/error_page/renderer/net_error_helper_core.cc

diff --git a/components/error_page/renderer/net_error_helper_core.cc b/components/error_page/renderer/net_error_helper_core.cc

index 8a9977c5b27ec4ec05c8916f3cb2eeb21b6f459c..9a92d742e6c40c2ca0eff58a64c0c39069189026 100644

--- a/components/error_page/renderer/net_error_helper_core.cc

+++ b/components/error_page/renderer/net_error_helper_core.cc

@@ -150,7 +150,7 @@ bool ShouldUseFixUrlServiceForError(const blink::WebURLError& error,

// Don't use the correction service for HTTPS (for privacy reasons).

GURL unreachable_url(error.unreachableURL);

- if (GURL(unreachable_url).SchemeIsSecure())

+ if (GURL(unreachable_url).SchemeIsCryptographic())

return false;

std::string domain = error.domain.utf8();