Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1101173002: Revert of Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.) (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.) (patchset #1 id:1 of https://codereview.chromium.org/1087133005/) Reason for revert: WinHeapDumpProviderTest.GetHeapInformation is failing on XP Tests (1) bot. https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/37137 Original issue's description: > Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.) > > Reason of reland: fixed gn files. > > Add a WinHeap dump provider to the memory profiler. > > TBR=nduca@chromium.org > BUG=466141 > > Committed: https://crrev.com/61dfbd59a9f6424197a1c1fadde0703d5ca65446 > Cr-Commit-Position: refs/heads/master@{#326573} TBR=primiano@chromium.org,rnk@chromium.org,sebmarchand@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466141 Committed: https://crrev.com/f4374b4302d27e155c1a74b1acc910b55d00148c Cr-Commit-Position: refs/heads/master@{#326633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -248 lines) Patch
M base/trace_event/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M base/trace_event/trace_event.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D base/trace_event/winheap_dump_provider_win.h View 1 chunk +0 lines, -54 lines 0 comments Download
D base/trace_event/winheap_dump_provider_win.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D base/trace_event/winheap_dump_provider_win_unittest.cc View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Justin Donnelly
Created Revert of Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.)
5 years, 8 months ago (2015-04-23 20:36:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101173002/1
5 years, 8 months ago (2015-04-23 20:36:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 20:37:55 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f4374b4302d27e155c1a74b1acc910b55d00148c Cr-Commit-Position: refs/heads/master@{#326633}
5 years, 8 months ago (2015-04-23 20:39:40 UTC) #4
Sébastien Marchand
5 years, 8 months ago (2015-04-24 00:28:37 UTC) #5
Message was sent while issue was closed.
Sorry for that, I'll try this on an XP machine to understand what's going on
here... And it seems that I should maybe disable this test under DrMemory as it
looks like a false positive...

Powered by Google App Engine
This is Rietveld 408576698