Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1101103004: Revert of ui: Clean up damaged rects and clear them after painting. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
Reviewers:
danakj, sky, piman
CC:
chromium-reviews, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, enne (OOO), piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ui: Clean up damaged rects and clear them after painting. (patchset #2 id:20001 of https://codereview.chromium.org/1080633009/) Reason for revert: ash_unittests are timing out on Win8 Aura and Linux ChromiumOS Tests (dbg)(1) bot and this CL is suspected to be the cause of the problem. Original issue's description: > ui: Clean up damaged rects and clear them after painting. > > This cleans up some of the damage rects code by converting the SkRegion > to a cc::Region, allowing use of gfx::Rects. It moves the recursion > over the Layer tree out to Compositor instead of on Layer. > > And we keep the damaged_region_ valid until the layer is painted. This > will allow us to pass that damaged_region_ to the painting code with > impl-side slimming paint, because with impl-side painting, the paint > clip rect can be larger than the invalidations (as large as the whole > layer). > > R=piman@chromium.org, sky > BUG=466426 > > Committed: https://crrev.com/a5e585868e16ce53c990f764d4943592f11749aa > Cr-Commit-Position: refs/heads/master@{#326547} TBR=piman@chromium.org,sky@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466426 Committed: https://crrev.com/1e3ddda564efbaa41286a6fbb0b0b089c20a5a9b Cr-Commit-Position: refs/heads/master@{#326637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M content/browser/compositor/reflector_impl_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M ui/compositor/layer.h View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/compositor/layer.cc View 4 chunks +28 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of ui: Clean up damaged rects and clear them after painting.
5 years, 8 months ago (2015-04-23 20:53:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101103004/1
5 years, 8 months ago (2015-04-23 20:54:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 20:55:47 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:56:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e3ddda564efbaa41286a6fbb0b0b089c20a5a9b
Cr-Commit-Position: refs/heads/master@{#326637}

Powered by Google App Engine
This is Rietveld 408576698