Clean up ObserverList Pointers to use nullptr instad of NULL or 0

Clean up ObserverList Pointers to use nullptr instad of NULL or 0

We expect the type to be ObserverType*, so let's use nullptr.

Committed: https://crrev.com/6f5e423c3c04e8952752368bb4a9abdea247a12a
Cr-Commit-Position: refs/heads/master@{#326679}

[robliao, 2015-04-23 18:13:21]

robliao@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-04-23 20:04:34]

Might as do nullptr.

[robliao, 2015-04-23 20:12:24]

On 2015/04/23 20:04:34, Lei Zhang wrote:
> Might as do nullptr.

I would like to, but the issue seemed unsettled, especially with regards to the
number of uses in the codebase.
https://code.google.com/p/chromium/codesearch#search/&q=nullptr%20-file:third...

There was
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/4mijeJHzxLg/dis...
and
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/oQunP1HmIfs/dis...

Are the floodgates officially opened for new code?

[Lei Zhang, 2015-04-23 20:18:30]

On 2015/04/23 20:12:24, robliao wrote:
> Are the floodgates officially opened for new code?

It's been open for a while. Search for nullptr on
https://chromium-cpp.appspot.com/

[robliao, 2015-04-23 21:04:24]

On 2015/04/23 20:18:30, Lei Zhang wrote:
> On 2015/04/23 20:12:24, robliao wrote:
> > Are the floodgates officially opened for new code?
> 
> It's been open for a while. Search for nullptr on
> https://chromium-cpp.appspot.com/

Cool link! I must have missed an announcement for this site. Updated observer
list and friends.

[Lei Zhang, 2015-04-23 21:07:33]

lgtm

Remember to update the CL description as well.

https://codereview.chromium.org/1101103002/diff/20001/base/observer_list.h
File base/observer_list.h (right):

https://codereview.chromium.org/1101103002/diff/20001/base/observer_list.h#ne...
base/observer_list.h:206: static_cast<ObserverType*>(nullptr)),
observers_.end());
Can you check to see if you can get rid of the static_cast?

[robliao, 2015-04-23 21:27:28]

https://codereview.chromium.org/1101103002/diff/20001/base/observer_list.h
File base/observer_list.h (right):

https://codereview.chromium.org/1101103002/diff/20001/base/observer_list.h#ne...
base/observer_list.h:206: static_cast<ObserverType*>(nullptr)),
observers_.end());
On 2015/04/23 21:07:33, Lei Zhang wrote:
> Can you check to see if you can get rid of the static_cast?

MSVC was cool with it, but MSVC tends to be more forgiving. I'll let the CQ find
out about the other compilers.

[robliao, 2015-04-23 21:27:34]

The CQ bit was checked by robliao@chromium.org

[robliao, 2015-04-23 21:27:34]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1101103002/#ps40001
(title: "Quick Update")

[commit-bot: I haz the power, 2015-04-23 21:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1101103002/40001

[commit-bot: I haz the power, 2015-04-23 22:46:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-23 22:50:06]

Patchset 3 (id:??) landed as
https://crrev.com/6f5e423c3c04e8952752368bb4a9abdea247a12a
Cr-Commit-Position: refs/heads/master@{#326679}