Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1101093002: Remove some needless base:: from base::File. (Closed)

Created:
5 years, 8 months ago by Dan Beam
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some needless base:: from base::File. R=thestig@chromium.org BUG=none TEST=less code Committed: https://crrev.com/38d002a2eb1ea031fb98089e8baa8b0e0b9d0bfd Cr-Commit-Position: refs/heads/master@{#326654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M base/files/file.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/files/file_posix.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M base/files/file_win.cc View 12 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 8 months ago (2015-04-23 17:03:04 UTC) #1
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-23 20:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101093002/1
5 years, 8 months ago (2015-04-23 20:43:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 21:42:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 21:43:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38d002a2eb1ea031fb98089e8baa8b0e0b9d0bfd
Cr-Commit-Position: refs/heads/master@{#326654}

Powered by Google App Engine
This is Rietveld 408576698