Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1101053002:
Apply automatic range checks to content enum types across IPC. (Closed)
|
Created:
5 years, 8 months ago by payal.pandey Modified:
5 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionApply automatic range checks to content enum types across IPC.
This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.
BUG=246708
Committed: https://crrev.com/3971e7fbbf4f3c2037d5befedaf3160260f99056
Cr-Commit-Position: refs/heads/master@{#327687}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Incoporated review comments #
Messages
Total messages: 26 (9 generated)
payal.pandey@samsung.com changed reviewers: + dcheng@chromium.org, michaeln@chromium.org
Please have a look, Thanks
https://codereview.chromium.org/1101053002/diff/1/storage/common/quota/quota_... File storage/common/quota/quota_status_code.h (right): https://codereview.chromium.org/1101053002/diff/1/storage/common/quota/quota_... storage/common/quota/quota_status_code.h:22: kQuotaStatusLast = kQuotaStatusUnknown, This is -1. This will filter out a lot of legitimate values of WebStorageQuotaError.
Incorporated the review comments. Please have a look, Thanks.
On 2015/04/24 13:04:08, payal.pandey wrote: > Incorporated the review comments. > Please have a look, Thanks. Please review, and give feedback if there are more changes need to be done. Thanks
Please have a look again, Thanks.
On 2015/04/29 10:27:30, payal.pandey wrote: > Please have a look again, Thanks. @dcheng : Please review the CL, Thanks.
lgtm
The CQ bit was checked by payal.pandey@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101053002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
payal.pandey@samsung.com changed reviewers: + kinuko@chromium.org
On 2015/04/29 19:32:34, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) @michaeln & @kinuko: please review the CL, Thanks.
On 2015/04/29 19:32:34, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) @michaeln & @kinuko: please review the CL, Thanks.
lgtm
The CQ bit was checked by payal.pandey@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101053002/20001
The CQ bit was unchecked by payal.pandey@samsung.com
The CQ bit was checked by payal.pandey@samsung.com
The CQ bit was checked by payal.pandey@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101053002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3971e7fbbf4f3c2037d5befedaf3160260f99056 Cr-Commit-Position: refs/heads/master@{#327687}
Message was sent while issue was closed.
jackiecline33@gmail.com changed reviewers: + jackiecline33@gmail.com
Message was sent while issue was closed.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
