Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1101033002: Update {virtual,override} to follow C++11 style in remoting. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
weitao, dcaiafa
CC:
chromium-reviews, stevenjb+watch_chromium.org, dcheng, oshima+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in remoting. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497 Cr-Commit-Position: refs/heads/master@{#326582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -170 lines) Patch
M remoting/base/breakpad_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/audio_capturer_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromeos/aura_desktop_capturer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/clipboard_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/continue_window_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/curtain_mode_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/daemon_process_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/daemon_process_win.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_resizer_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/host/desktop_session_win.h View 2 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/desktop_session_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/gnubby_auth_handler_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/host_event_logger_win.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/host_mock_objects.h View 8 chunks +15 lines, -15 lines 0 comments Download
M remoting/host/input_injector_win.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/pairing_registry_delegate_win.h View 2 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/pairing_registry_delegate_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/sas_injector_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.h View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/win/chromoting_module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/win/host_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_desktop_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/win/session_desktop_environment.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/win/session_input_injector.h View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/win/session_input_injector.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/win/unprivileged_process_delegate.h View 1 chunk +8 lines, -8 lines 0 comments Download
M remoting/host/win/worker_process_launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/protocol/monitored_video_stub_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/mock_signal_strategy.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ncarter (slow)
Hi weitaosu@ -- please review
5 years, 8 months ago (2015-04-23 04:02:08 UTC) #2
dcaiafa
lgtm
5 years, 8 months ago (2015-04-23 17:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101033002/1
5 years, 8 months ago (2015-04-23 18:00:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 18:22:41 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 18:24:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/697f429d75099ea436aee5beb9ea0c26c7dea497
Cr-Commit-Position: refs/heads/master@{#326582}

Powered by Google App Engine
This is Rietveld 408576698