Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 110103002: Pretty printing for array code stubs. (Closed)

Created:
7 years ago by mvstanton
Modified:
7 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Pretty printing for array code stubs. The minor keys encode things like specialized ElementsKind for each stub. This can be useful to see in disassembly traces. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18369

Patch Set 1 #

Patch Set 2 : Improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/code-stubs.h View 5 chunks +16 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Benedikt, can you have a look at this disassembly print support for ArrayConstructorStub and ...
7 years ago (2013-12-09 10:09:55 UTC) #1
Benedikt Meurer
LGTM
7 years ago (2013-12-09 13:06:33 UTC) #2
mvstanton
7 years ago (2013-12-18 22:51:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698