Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1101023002: Update {virtual,override} to follow C++11 style in printing. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in printing. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/bc76161f2f357116c647446afdc4de083712224a Cr-Commit-Position: refs/heads/master@{#327173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -46 lines) Patch
M printing/backend/print_backend_win.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M printing/emf_win.h View 2 chunks +16 lines, -16 lines 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +3 lines, -3 lines 0 comments Download
M printing/printing_context_system_dialog_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/printing_context_win.h View 1 chunk +14 lines, -14 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ncarter (slow)
alekseys: please review
5 years, 8 months ago (2015-04-23 03:58:06 UTC) #2
ncarter (slow)
aleksey: ping
5 years, 8 months ago (2015-04-24 16:14:16 UTC) #3
Aleksey Shlyapnikov
lgtm
5 years, 8 months ago (2015-04-27 21:43:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101023002/1
5 years, 8 months ago (2015-04-27 21:44:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 23:30:58 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 23:31:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc76161f2f357116c647446afdc4de083712224a
Cr-Commit-Position: refs/heads/master@{#327173}

Powered by Google App Engine
This is Rietveld 408576698