Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1101013002: Update {virtual,override} to follow C++11 style in gpu. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Nico, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in gpu. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. NOTRY=true BUG=417463 Committed: https://crrev.com/bd48e5909786f81f75052d45e770c823b5935d3e Cr-Commit-Position: refs/heads/master@{#326845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-23 02:54:13 UTC) #2
no sievers
lgtm
5 years, 8 months ago (2015-04-23 20:27:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1
5 years, 8 months ago (2015-04-23 20:37:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/19065)
5 years, 8 months ago (2015-04-23 21:31:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1
5 years, 8 months ago (2015-04-23 22:22:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/19130)
5 years, 8 months ago (2015-04-23 23:22:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1
5 years, 8 months ago (2015-04-24 03:06:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/19224)
5 years, 8 months ago (2015-04-24 03:55:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1
5 years, 8 months ago (2015-04-24 16:11:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/19395)
5 years, 8 months ago (2015-04-24 17:02:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1
5 years, 8 months ago (2015-04-24 18:00:53 UTC) #21
ncarter (slow)
This is failing to land because of a preexisting missing build dependency (bug 481110); I'm ...
5 years, 8 months ago (2015-04-24 18:21:49 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 18:33:51 UTC) #23
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:34:42 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd48e5909786f81f75052d45e770c823b5935d3e
Cr-Commit-Position: refs/heads/master@{#326845}

Powered by Google App Engine
This is Rietveld 408576698