| 
 | 
 | 
 Chromium Code Reviews
 Chromium Code Reviews Issue 
            1101013002:
    Update {virtual,override} to follow C++11 style in gpu.  (Closed)
    
  
    Issue 
            1101013002:
    Update {virtual,override} to follow C++11 style in gpu.  (Closed) 
  | Created: 5 years, 8 months ago by ncarter (slow) Modified: 5 years, 8 months ago CC: chromium-reviews, piman+watch_chromium.org Base URL: https://chromium.googlesource.com/chromium/src.git@master Target Ref: refs/pending/heads/master Project: chromium Visibility: Public. | DescriptionUpdate {virtual,override} to follow C++11 style in gpu.
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.
This patch was manually generated using a regex and a text editor.
NOTRY=true
BUG=417463
Committed: https://crrev.com/bd48e5909786f81f75052d45e770c823b5935d3e
Cr-Commit-Position: refs/heads/master@{#326845}
   Patch Set 1 #
 Messages
    Total messages: 24 (10 generated)
     
 nick@chromium.org changed reviewers: + sievers@chromium.org 
 
 lgtm 
 The CQ bit was checked by nick@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) 
 The CQ bit was checked by nick@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) 
 The CQ bit was checked by nick@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) 
 The CQ bit was checked by nick@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) 
 The CQ bit was checked by thakis@chromium.org 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1101013002/1 
 This is failing to land because of a preexisting missing build dependency (bug 481110); I'm adding NOTRY=true to land it. 
 
            
              
                Message was sent while issue was closed.
              
            
             Committed patchset #1 (id:1) 
 
            
              
                Message was sent while issue was closed.
              
            
             Patchset 1 (id:??) landed as https://crrev.com/bd48e5909786f81f75052d45e770c823b5935d3e Cr-Commit-Position: refs/heads/master@{#326845} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
