ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html - Issue 1100993002: Implement md-settings network lists.

Side by Side Diff: ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Issue 1100993002: Implement md-settings network lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/internet_page/network_summary_item_style.html ('K') | « chrome/browser/resources/settings/settings_resources.grd ('k') | ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js » ('j') | ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/paper-button/paper-button.ht ml">
	michaelpg 2015/04/23 02:16:29 import core-icon as well import core-icon as well stevenjb 2015/04/24 01:25:26 Done. Show quoted text On 2015/04/23 02:16:29, michaelpg wrote: > import core-icon as well Done.
	3

	4 <polymer-element name="cr-expand-button">

	5 <template>

	6 <paper-button id="expand" disabled="{{disabled}}"
	michaelpg 2015/04/23 02:16:29 If there's no need to give the button an ID, let's If there's no need to give the button an ID, let's leave it out. michaelpg 2015/04/23 02:16:29 paper-button (through CoreFocusable) has a "toggle paper-button (through CoreFocusable) has a "toggle" attribute which will make the "active" attribute do what you currently do for "expanded" -- so you might be able to just set <paper-button toggle active="{{expanded}}" disabled="{{disabled}}"> and not have to manually wire up click click events. See "Toggle buttons" in https://www.polymer-project.org/0.5/components/paper-button/demo.html Jeremy Klein 2015/04/23 18:21:15 It seems like core-icon-button or paper-icon-butto It seems like core-icon-button or paper-icon-button is a better fit here. stevenjb 2015/04/24 01:25:26 paper-icon-button only has a single icon. Using ' Show quoted text On 2015/04/23 18:21:15, Jeremy Klein wrote: > It seems like core-icon-button or paper-icon-button is a better fit here. paper-icon-button only has a single icon. Using 'active' (not mentioned in paper-button docs, thankyouverymuch) highlights the button, which looks a little odd, but we can probably change that with styling, and will give the UX folks more to think about :) Done. michaelpg 2015/04/24 19:35:37 Yeah, you have to click through the whole inherita Show quoted text On 2015/04/24 01:25:26, stevenjb wrote: > On 2015/04/23 18:21:15, Jeremy Klein wrote: > > It seems like core-icon-button or paper-icon-button is a better fit here. > > paper-icon-button only has a single icon. > > Using 'active' (not mentioned in paper-button docs, thankyouverymuch) highlights > the button, which looks a little odd, but we can probably change that with > styling, and will give the UX folks more to think about :) Done. > > Yeah, you have to click through the whole inheritance chain because they don't show "inherited" attributes for mixins :-( But I'm glad we made this work. Jeremy Klein 2015/04/27 22:36:10 I'm not suggesting we get rid of this wrapper, jus Show quoted text On 2015/04/24 01:25:26, stevenjb wrote: > On 2015/04/23 18:21:15, Jeremy Klein wrote: > > It seems like core-icon-button or paper-icon-button is a better fit here. > > paper-icon-button only has a single icon. > I'm not suggesting we get rid of this wrapper, just that we wrap paper-icon-button instead of paper-button and core-icon. paper-icon-button essentially does exactly what you're doing here and you could use the same exact binding in the icon attribute. stevenjb 2015/04/28 01:05:02 Ah. Yes, that works, and we get a cute round hilig Show quoted text On 2015/04/27 22:36:10, Jeremy Klein wrote: > On 2015/04/24 01:25:26, stevenjb wrote: > > On 2015/04/23 18:21:15, Jeremy Klein wrote: > > > It seems like core-icon-button or paper-icon-button is a better fit here. > > > > paper-icon-button only has a single icon. > > > > I'm not suggesting we get rid of this wrapper, just that we wrap > paper-icon-button instead of paper-button and core-icon. paper-icon-button > essentially does exactly what you're doing here and you could use the same exact > binding in the icon attribute. > Ah. Yes, that works, and we get a cute round hilight instead of a squarish one. Done.
	7 on-click="{{toggleExpanded}}">

	8 <core-icon icon="{{expanded ? 'expand-less' : 'expand-more'}}">

	9 </core-icon>

	10 </paper-button>

	11 </template>

	12 <script src="cr_expand_button.js"></script>

	13 </polymer-element>

OLD	NEW