components/cronet/android/cronet_url_request_adapter.cc - Issue 1100923002: [cronet] Pass total bytes received to CronetUrlRequest.onSucceeded()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 1100923002: [cronet] Pass total bytes received to CronetUrlRequest.onSucceeded() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove more dead code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.h ('k') | components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc

index cec7756e122deaaa4e4bc9cc737d989b3ffecc96..096b312356978df40c5b1a3fcd0546ec34128db9 100644

--- a/components/cronet/android/cronet_url_request_adapter.cc

+++ b/components/cronet/android/cronet_url_request_adapter.cc

@@ -232,12 +232,6 @@ jboolean CronetURLRequestAdapter::GetWasCached(JNIEnv* env,

return url_request_->response_info().was_cached;

}

-int64 CronetURLRequestAdapter::GetTotalReceivedBytes(JNIEnv* env,

- jobject jcaller) const {

- DCHECK(context_->IsOnNetworkThread());

- return url_request_->GetTotalReceivedBytes();

// net::URLRequest::Delegate overrides (called on network thread).

void CronetURLRequestAdapter::OnReceivedRedirect(

@@ -278,7 +272,8 @@ void CronetURLRequestAdapter::OnReadCompleted(net::URLRequest* request,

read_buffer_ = nullptr;

} else {

JNIEnv* env = base::android::AttachCurrentThread();

- cronet::Java_CronetUrlRequest_onSucceeded(env, owner_.obj());

+ cronet::Java_CronetUrlRequest_onSucceeded(

+ env, owner_.obj(), url_request_->GetTotalReceivedBytes());

}