Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1100903003: Move android.py to devtools. (Closed)

Created:
5 years, 8 months ago by ppi
Modified:
5 years, 8 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move android.py to devtools. Now that android.py has no external dependencies, this patch extracts it to devtools. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d4162fc645e84f91ceecfdd8699fce5e2016fa87

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -392 lines) Patch
A + mojo/devtools/common/pylib/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/devtools/common/pylib/android.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/tools/android_mojo_shell.py View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/tools/apptest_runner.py View 1 chunk +4 lines, -1 line 0 comments Download
A mojo/tools/devtools.py View 1 1 chunk +15 lines, -0 lines 0 comments Download
D mojo/tools/mopy/android.py View 1 chunk +0 lines, -392 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Ben, ptal.
5 years, 8 months ago (2015-04-22 14:00:37 UTC) #1
ppi
Whoops, I forgot to add you as the reviewer :). Ptal.
5 years, 8 months ago (2015-04-22 14:26:05 UTC) #3
qsr
lgtm
5 years, 8 months ago (2015-04-22 14:33:21 UTC) #4
ppi
5 years, 8 months ago (2015-04-22 14:37:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d4162fc645e84f91ceecfdd8699fce5e2016fa87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698