DescriptionRevert of bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow. (patchset #4 id:60001 of https://codereview.chromium.org/1100693002/)
Reason for revert:
This causes the following test to fail:
out/Release/browser_tests --gtest_filter=ActivityLogApiTest.TriggerEvent
This is preventing Blink from rolling:
https://codereview.chromium.org/1102483002
Original issue's description:
> bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow.
>
> Custom toV8(EventTarget*) has been handling LocalDOMWindow in a special
> manner so that custom toV8(DOMWindow*) is always used. However, when
> RemoteDOMWindow, and DOMWindow as their superclass, were introduced, we
> didn't add the same support for RemoteDOMWindow nor DOMWindow. It was
> wrong.
>
> When toV8(EventTarget*) is called with a RemoteDOMWindow before
> installDOMWindow is called, toV8(EventTarget*) calls
> RemoteDOMWindow::wrap() and it creates a wrapper. After that, when
> installDOMWindow is called, the wrapper already exists for the
> RemoteDOMWindow and it causes crash.
>
> I think this is the cause of mysterious crashes around installDOMWindow.
>
> This CL fixes:
> - Makes sure that DOMWindow::wrap is never called.
> - Calls toV8(DOMWindow*) for not only LocalDOMWindow but also
> RemoteDOMWindow.
>
> I've confirmed that crash occurs at www.nhl.com with --site-per-process
> specified, and fix with this CL.
>
> BUG=478890, 477410, 475880
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194193
TBR=dcheng@chromium.org,haraken@chromium.org,yukishiino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478890, 477410, 475880
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194202
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|