Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1100893002: Revert of bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow. (Closed)

Created:
5 years, 8 months ago by alancutter (OOO until 2018)
Modified:
5 years, 8 months ago
Reviewers:
haraken, dcheng, Yuki
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow. (patchset #4 id:60001 of https://codereview.chromium.org/1100693002/) Reason for revert: This causes the following test to fail: out/Release/browser_tests --gtest_filter=ActivityLogApiTest.TriggerEvent This is preventing Blink from rolling: https://codereview.chromium.org/1102483002 Original issue's description: > bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow. > > Custom toV8(EventTarget*) has been handling LocalDOMWindow in a special > manner so that custom toV8(DOMWindow*) is always used. However, when > RemoteDOMWindow, and DOMWindow as their superclass, were introduced, we > didn't add the same support for RemoteDOMWindow nor DOMWindow. It was > wrong. > > When toV8(EventTarget*) is called with a RemoteDOMWindow before > installDOMWindow is called, toV8(EventTarget*) calls > RemoteDOMWindow::wrap() and it creates a wrapper. After that, when > installDOMWindow is called, the wrapper already exists for the > RemoteDOMWindow and it causes crash. > > I think this is the cause of mysterious crashes around installDOMWindow. > > This CL fixes: > - Makes sure that DOMWindow::wrap is never called. > - Calls toV8(DOMWindow*) for not only LocalDOMWindow but also > RemoteDOMWindow. > > I've confirmed that crash occurs at www.nhl.com with --site-per-process > specified, and fix with this CL. > > BUG=478890, 477410, 475880 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194193 TBR=dcheng@chromium.org,haraken@chromium.org,yukishiino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478890, 477410, 475880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -30 lines) Patch
M Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/MakeNames.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/RemoteDOMWindow.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/RemoteDOMWindow.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
alancutter (OOO until 2018)
Created Revert of bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow.
5 years, 8 months ago (2015-04-22 08:29:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100893002/1
5 years, 8 months ago (2015-04-22 08:29:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194202
5 years, 8 months ago (2015-04-22 08:29:50 UTC) #3
haraken
5 years, 8 months ago (2015-04-22 08:29:57 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698