Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100873004: FontFace sync (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 6 months ago
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-css, ed+blinkwatch_opera.com, vivekg, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the CSS Font Loading interfaces with the spec http://dev.w3.org/csswg/css-font-loading/ There are no changes to the generated code, other than order. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196215

Patch Set 1 #

Patch Set 2 : sync more #

Patch Set 3 : final touches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M Source/core/css/DocumentFontFaceSet.idl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/FontFace.idl View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFaceDescriptors.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/FontFaceSet.idl View 1 1 chunk +23 lines, -8 lines 0 comments Download
M Source/core/css/FontFaceSetForEachCallback.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/FontFaceSetLoadEvent.idl View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
philipj_slow
sync more
5 years, 8 months ago (2015-04-23 15:38:59 UTC) #1
philipj_slow
ksakamoto@, can you check that you're OK with your name on these TODOs? jl@, sanity ...
5 years, 6 months ago (2015-05-29 21:42:39 UTC) #3
Kunihiko Sakamoto
lgtm Thanks for doing this!
5 years, 6 months ago (2015-06-01 02:04:26 UTC) #4
Jens Widell
LGTM
5 years, 6 months ago (2015-06-01 06:03:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100873004/40001
5 years, 6 months ago (2015-06-01 08:07:13 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 09:30:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196215

Powered by Google App Engine
This is Rietveld 408576698