Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1100853003: Make quiesence test best-effort for the blink_style benchmark (Closed)

Created:
5 years, 8 months ago by dstockwell
Modified:
5 years, 7 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make quiesence test best-effort in the blink_style benchmark Some sites, notably techcrunch, in top25 were failing to reach readyState complete or quiesence due to continual requests (possibly an artifact of the wpr). As this benchmark normalizes/categories results, it shouldn't be necessary to reach the same state on every run. Also switches to a tighter tracing category which allows the reference build to be re-enabled, since the metrics will not appear there until they are valid to be consumed by the blink_style measurement. BUG=479048 Committed: https://crrev.com/13e95bde55343d1351b4879be84e13f9ac01bec2 Cr-Commit-Position: refs/heads/master@{#327235}

Patch Set 1 #

Patch Set 2 : Enable unit test #

Patch Set 3 : Rebase? #

Patch Set 4 : Make quiesence test best-effort #

Patch Set 5 : Skip updateStyle measurement when resolverAccessCount is missing #

Total comments: 1

Patch Set 6 : Add comment #

Patch Set 7 : Fix typo :/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M tools/perf/benchmarks/blink_style.py View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/measurements/blink_style.py View 1 2 3 4 5 6 4 chunks +15 lines, -6 lines 0 comments Download
M tools/perf/measurements/blink_style_unittest.py View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
dstockwell
5 years, 8 months ago (2015-04-27 02:37:45 UTC) #2
dstockwell
Perf try-jobs: blink_style.key_mobile_sites on trybot-android-nexus7 https://codereview.chromium.org/1092983004 blink_style.polymer on trybot-android-nexus7 https://codereview.chromium.org/1103103002 blink_style.polymer on trybot-linux https://codereview.chromium.org/1107813002 blink_style.polymer ...
5 years, 8 months ago (2015-04-27 02:38:01 UTC) #3
dstockwell
http://techcrunch.com failed in blink_style.top_25 by timing out in WaitForDocumentReadyStateToBeComplete
5 years, 8 months ago (2015-04-27 02:57:24 UTC) #4
dstockwell
On 2015/04/27 at 02:57:24, dstockwell wrote: > http://techcrunch.com failed in blink_style.top_25 by timing out in ...
5 years, 8 months ago (2015-04-27 07:49:20 UTC) #5
dstockwell
PTAL New perf try jobs: mac blink_style.top_25: https://codereview.chromium.org/1102283002 linux blink_style.top_25: https://codereview.chromium.org/1103133002 nexus7 blink_style.polymer: https://codereview.chromium.org/1104043003 nexus7 ...
5 years, 8 months ago (2015-04-27 10:28:55 UTC) #6
dstockwell
Switching to the blink_style trace category now depends on https://codereview.chromium.org/1102293002
5 years, 8 months ago (2015-04-27 11:02:22 UTC) #7
dtu
Just one comment. lgtm otherwise https://codereview.chromium.org/1100853003/diff/80001/tools/perf/measurements/blink_style.py File tools/perf/measurements/blink_style.py (right): https://codereview.chromium.org/1100853003/diff/80001/tools/perf/measurements/blink_style.py#newcode34 tools/perf/measurements/blink_style.py:34: except exceptions.TimeoutException: ? Can ...
5 years, 8 months ago (2015-04-27 13:02:21 UTC) #8
sullivan
On 2015/04/27 10:28:55, dstockwell wrote: > PTAL > > New perf try jobs: > mac ...
5 years, 8 months ago (2015-04-27 13:06:06 UTC) #9
dstockwell
On 2015/04/27 at 13:06:06, sullivan wrote: > On 2015/04/27 10:28:55, dstockwell wrote: > > PTAL ...
5 years, 7 months ago (2015-04-28 01:31:54 UTC) #10
dstockwell
On 2015/04/28 at 01:31:54, dstockwell wrote: > On 2015/04/27 at 13:06:06, sullivan wrote: > > ...
5 years, 7 months ago (2015-04-28 03:38:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100853003/120001
5 years, 7 months ago (2015-04-28 04:43:04 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 7 months ago (2015-04-28 05:37:42 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 05:38:34 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/13e95bde55343d1351b4879be84e13f9ac01bec2
Cr-Commit-Position: refs/heads/master@{#327235}

Powered by Google App Engine
This is Rietveld 408576698