Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1100823004: Remove AccessibilityInjector support. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
CC:
aboxhall+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, David Trainor- moved to gerrit, dtseng+watch_chromium.org, jam, je_julie(Not used), jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AccessibilityInjector support. AccessibilityInjector is no longer used as it was needed for ICS support and Chrome only support API 16 and above now. BUG=479334 TBR=damienv@chromium.org Committed: https://crrev.com/eeffed48a0847161775df9cec591446b80c83e54 Cr-Commit-Position: refs/heads/master@{#326419}

Patch Set 1 #

Total comments: 4

Patch Set 2 : dmazzoni's comments #

Total comments: 2

Patch Set 3 : boliu's nits #

Patch Set 4 : Update Chrome cast shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1094 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 2 chunks +0 lines, -16 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ChromeContentViewClient.java View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTabModelSelector.java View 2 chunks +1 line, -2 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 1 6 chunks +22 lines, -29 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 14 chunks +4 lines, -142 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/JellyBeanContentView.java View 1 chunk +0 lines, -37 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 1 chunk +0 lines, -457 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java View 1 chunk +0 lines, -268 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopAccessibilityInjector.java View 1 chunk +0 lines, -93 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-21 22:20:41 UTC) #2
dmazzoni
lgtm https://chromiumcodereview.appspot.com/1100823004/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://chromiumcodereview.appspot.com/1100823004/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode2932 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2932: public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) { You can delete ...
5 years, 8 months ago (2015-04-21 22:39:02 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1100823004/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://chromiumcodereview.appspot.com/1100823004/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode2932 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:2932: public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) { On 2015/04/21 22:39:02, dmazzoni ...
5 years, 8 months ago (2015-04-21 23:23:02 UTC) #4
aurimas (slooooooooow)
+boliu for android_webview/
5 years, 8 months ago (2015-04-21 23:23:41 UTC) #6
David Trainor- moved to gerrit
I forget, why did we have the LollipopAccessibilityInjector/why can we get rid of it now? ...
5 years, 8 months ago (2015-04-22 01:30:06 UTC) #7
dmazzoni
I think LollipopAccessibilityInjector was just because some APIs were deprecated and we switched to the ...
5 years, 8 months ago (2015-04-22 03:45:35 UTC) #8
boliu
lgtm % one comment \o/ https://chromiumcodereview.appspot.com/1100823004/diff/20001/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (left): https://chromiumcodereview.appspot.com/1100823004/diff/20001/android_webview/java/src/org/chromium/android_webview/AwContents.java#oldcode2247 android_webview/java/src/org/chromium/android_webview/AwContents.java:2247: public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) ...
5 years, 8 months ago (2015-04-22 06:33:21 UTC) #9
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1100823004/diff/20001/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (left): https://chromiumcodereview.appspot.com/1100823004/diff/20001/android_webview/java/src/org/chromium/android_webview/AwContents.java#oldcode2247 android_webview/java/src/org/chromium/android_webview/AwContents.java:2247: public void onInitializeAccessibilityNodeInfo(AccessibilityNodeInfo info) { On 2015/04/22 at 06:33:21, ...
5 years, 8 months ago (2015-04-22 21:40:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100823004/40001
5 years, 8 months ago (2015-04-22 21:52:29 UTC) #13
aurimas (slooooooooow)
TBR damienv@chromium.org for trivial CastWindowAndroid change.
5 years, 8 months ago (2015-04-22 23:08:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100823004/60001
5 years, 8 months ago (2015-04-22 23:10:29 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-23 01:14:49 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 01:15:55 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eeffed48a0847161775df9cec591446b80c83e54
Cr-Commit-Position: refs/heads/master@{#326419}

Powered by Google App Engine
This is Rietveld 408576698