ozone: Add ability to set clinet capabilities which we will need for atomic

ozone: Add ability to set client capabilities which we will need for atomic

Committed: https://crrev.com/e5983b7fde9d576bd514490106564e2238eb0713
Cr-Commit-Position: refs/heads/master@{#326860}

Committed: https://crrev.com/cde126fd13d4a32de44da0b2570590f9df6167d5
Cr-Commit-Position: refs/heads/master@{#329907}

[achaulk, 2015-04-24 19:34:22]

achaulk@chromium.org changed reviewers:
+ dnicoara@chromium.org

[dnicoara, 2015-04-24 19:38:55]

lgtm with nit

https://codereview.chromium.org/1100803004/diff/1/ui/ozone/platform/drm/gpu/d...
File ui/ozone/platform/drm/gpu/drm_device.cc (right):

https://codereview.chromium.org/1100803004/diff/1/ui/ozone/platform/drm/gpu/d...
ui/ozone/platform/drm/gpu/drm_device.cc:508: return
!drmSetClientCap(file_.GetPlatformFile(), capability, value);
nit:DCHECK(file_.IsValid());

[achaulk, 2015-04-24 19:45:29]

The CQ bit was checked by achaulk@chromium.org

[achaulk, 2015-04-24 19:45:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/1100803004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-04-24 19:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100803004/20001

[commit-bot: I haz the power, 2015-04-24 20:09:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-24 20:10:10]

Patchset 2 (id:??) landed as
https://crrev.com/e5983b7fde9d576bd514490106564e2238eb0713
Cr-Commit-Position: refs/heads/master@{#326860}

[Nikita (slow), 2015-04-27 08:38:51]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1104013002/ by nkostylev@chromium.org.

The reason for reverting is: Speculative revert - Linux ChromiumOS Ozone Tests
is broken.
http://goo.gl/vykWsG.

[achaulk, 2015-05-14 17:37:11]

PTAL for reland, added new defice

[dnicoara, 2015-05-14 17:43:18]

Also, missing GN changes.

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
File ui/ozone/platform/drm/drm.gypi (right):

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
ui/ozone/platform/drm/drm.gypi:110: ['use_evdev_gestures==1', {
Lets not re-use event related defines for this kind of behavior. Add a DRM
specific flag.

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
ui/ozone/platform/drm/drm.gypi:112: 'IS_DEVICE_BUILD',
You should also name this appropriately.

[achaulk, 2015-05-14 18:26:25]

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
File ui/ozone/platform/drm/drm.gypi (right):

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
ui/ozone/platform/drm/drm.gypi:112: 'IS_DEVICE_BUILD',
On 2015/05/14 17:43:18, dnicoara wrote:
> You should also name this appropriately.

To what? OS_IS_REALLY_CHROMEOS?

[dnicoara, 2015-05-14 18:31:37]

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
File ui/ozone/platform/drm/drm.gypi (right):

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
ui/ozone/platform/drm/drm.gypi:112: 'IS_DEVICE_BUILD',
On 2015/05/14 18:26:24, achaulk wrote:
> On 2015/05/14 17:43:18, dnicoara wrote:
> > You should also name this appropriately.
> 
> To what? OS_IS_REALLY_CHROMEOS?

To SUPPORTS_SET_CLIENT_CAP or something similar. If you want, you can even use
'pkg-config --version libdrm' to figure out if the supplied version supports
said feature.

[achaulk, 2015-05-14 18:33:14]

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
File ui/ozone/platform/drm/drm.gypi (right):

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
ui/ozone/platform/drm/drm.gypi:112: 'IS_DEVICE_BUILD',
On 2015/05/14 18:31:37, dnicoara wrote:
> On 2015/05/14 18:26:24, achaulk wrote:
> > On 2015/05/14 17:43:18, dnicoara wrote:
> > > You should also name this appropriately.
> > 
> > To what? OS_IS_REALLY_CHROMEOS?
> 
> To SUPPORTS_SET_CLIENT_CAP or something similar. If you want, you can even use
> 'pkg-config --version libdrm' to figure out if the supplied version supports
> said feature.

We're also going to need to condition the atomic apis on this flag too, maybe
HAS_CHROMEOS_DRM?

[dnicoara, 2015-05-14 18:38:15]

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
File ui/ozone/platform/drm/drm.gypi (right):

https://codereview.chromium.org/1100803004/diff/60001/ui/ozone/platform/drm/d...
ui/ozone/platform/drm/drm.gypi:112: 'IS_DEVICE_BUILD',
On 2015/05/14 18:33:13, achaulk wrote:
> On 2015/05/14 18:31:37, dnicoara wrote:
> > On 2015/05/14 18:26:24, achaulk wrote:
> > > On 2015/05/14 17:43:18, dnicoara wrote:
> > > > You should also name this appropriately.
> > > 
> > > To what? OS_IS_REALLY_CHROMEOS?
> > 
> > To SUPPORTS_SET_CLIENT_CAP or something similar. If you want, you can even
use
> > 'pkg-config --version libdrm' to figure out if the supplied version supports
> > said feature.
> 
> We're also going to need to condition the atomic apis on this flag too, maybe
> HAS_CHROMEOS_DRM?

How about HAS_ATOMIC_DRM_API? Just because chromeos has it doesn't mean that you
can't build outside the CrOS chroot.

[achaulk, 2015-05-14 19:23:32]

Apparently the builders have been updated and the bug just wasn't closed, so I
should be able to re-land this without any build file changes now

[achaulk, 2015-05-14 19:23:42]

The CQ bit was checked by achaulk@chromium.org

[achaulk, 2015-05-14 19:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/1100803004/#ps80001
(title: "revert PS4")

[commit-bot: I haz the power, 2015-05-14 19:24:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100803004/80001

[commit-bot: I haz the power, 2015-05-14 19:48:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-14 19:49:14]

Patchset 5 (id:??) landed as
https://crrev.com/cde126fd13d4a32de44da0b2570590f9df6167d5
Cr-Commit-Position: refs/heads/master@{#329907}