Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1100803002: Make ganesh_app's GaneshView actually observe its View. (Closed)

Created:
5 years, 8 months ago by viettrungluu
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make ganesh_app's GaneshView actually observe its View. (Also make it draw a few more things, so that we can tell that it's tracking the view size correctly.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/41b4fdaba230f92fc5a50c3e499d453b5cb849fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M examples/ganesh_app/ganesh_view.cc View 4 chunks +15 lines, -1 line 0 comments Download
M services/kiosk_wm/kiosk_wm.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 8 months ago (2015-04-21 17:27:52 UTC) #1
jamesr
lgtm
5 years, 8 months ago (2015-04-21 17:29:34 UTC) #2
viettrungluu
5 years, 8 months ago (2015-04-21 17:35:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41b4fdaba230f92fc5a50c3e499d453b5cb849fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698