infra/publish_tarball: move export_tarball.py to recipes

infra/publish_tarball: move export_tarball.py to recipes

BUG=433338
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294987

[Paweł Hajdan Jr., 2015-04-21 16:44:25]

phajdan.jr@chromium.org changed reviewers:
+ mmoss@chromium.org

[pgervais, 2015-04-24 18:05:04]

pgervais@chromium.org changed reviewers:
+ pgervais@chromium.org

[pgervais, 2015-04-24 18:05:05]

Minor comments. Looks good otherwise.

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/resources/export_tarball.py (right):

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/resources/export_tarball.py:84: #
TODO(phajdan.jr): remove the workaround when it's not needed on the bot.
Maybe it's time. The oldest Python we have is 2.6, correct?

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/resources/export_tarball.py:150: # These
two commands are from src/DEPS; please keep them in sync.
I guess there is a similar comment in src/DEPS. Could you update it to reflect
the new location of this file? (or add it if it doesn't exist)

[Paweł Hajdan Jr., 2015-04-24 18:15:39]

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/resources/export_tarball.py (right):

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/resources/export_tarball.py:84: #
TODO(phajdan.jr): remove the workaround when it's not needed on the bot.
On 2015/04/24 18:05:05, pgervais wrote:
> Maybe it's time. The oldest Python we have is 2.6, correct?

We should be on 2.7 everywhere. I plan to look into this (and other cleanups of
this file), it just seems safer to copy it as-is for now.

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/resources/export_tarball.py:150: # These
two commands are from src/DEPS; please keep them in sync.
On 2015/04/24 18:05:05, pgervais wrote:
> I guess there is a similar comment in src/DEPS. Could you update it to reflect
> the new location of this file? (or add it if it doesn't exist)

I uploaded https://codereview.chromium.org/1105963002

The idea is this is only used for distro tarballs, and I don't want to burden
chrome devs with updating this, especially that now it'd be in a different repo
they're not familiar with.

[pgervais, 2015-04-24 18:32:22]

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/resources/export_tarball.py (right):

https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/resources/export_tarball.py:150: # These
two commands are from src/DEPS; please keep them in sync.
On 2015/04/24 18:15:39, Paweł Hajdan Jr. wrote:
> On 2015/04/24 18:05:05, pgervais wrote:
> > I guess there is a similar comment in src/DEPS. Could you update it to
reflect
> > the new location of this file? (or add it if it doesn't exist)
> 
> I uploaded https://codereview.chromium.org/1105963002
> 
> The idea is this is only used for distro tarballs, and I don't want to burden
> chrome devs with updating this, especially that now it'd be in a different
repo
> they're not familiar with.

Keeping two things in sync in two different repos is a recipe for disaster.
Can't we find a way to break this dependency for real?

[pgervais, 2015-04-24 18:57:32]

On 2015/04/24 18:32:22, pgervais wrote:
>
https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/chromium/resources/export_tarball.py
(right):
> 
>
https://codereview.chromium.org/1100783002/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/chromium/resources/export_tarball.py:150: # These
> two commands are from src/DEPS; please keep them in sync.
> On 2015/04/24 18:15:39, Paweł Hajdan Jr. wrote:
> > On 2015/04/24 18:05:05, pgervais wrote:
> > > I guess there is a similar comment in src/DEPS. Could you update it to
> reflect
> > > the new location of this file? (or add it if it doesn't exist)
> > 
> > I uploaded https://codereview.chromium.org/1105963002
> > 
> > The idea is this is only used for distro tarballs, and I don't want to
burden
> > chrome devs with updating this, especially that now it'd be in a different
> repo
> > they're not familiar with.
> 
> Keeping two things in sync in two different repos is a recipe for disaster.
> Can't we find a way to break this dependency for real?

Summary of offline discussion: if a disaster happens it would be too small to be
called 'disaster'. So lgtm.

[Paweł Hajdan Jr., 2015-04-24 19:06:47]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2015-04-24 19:07:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100783002/1

[commit-bot: I haz the power, 2015-04-24 19:11:15]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294987