base/thread_task_runner_handle_unittest.cc - Issue 1100773004: base: Remove most uses of MessageLoopProxy

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/thread_task_runner_handle_unittest.cc

Issue 1100773004: base: Remove most uses of MessageLoopProxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/thread_task_runner_handle.h"

	6

	7 #include "base/test/test_simple_task_runner.h"

	8 #include "testing/gtest/include/gtest/gtest.h"

	9

	10 namespace base {

	11
	danakj 2015/04/21 20:16:31 can you put the tests in an anon namespace inside can you put the tests in an anon namespace inside base? Sami 2015/04/23 17:48:25 Ack, this file shouldn't have been included in thi Show quoted text On 2015/04/21 20:16:31, danakj wrote: > can you put the tests in an anon namespace inside base? Ack, this file shouldn't have been included in this patch at all :( It didn't get compiled or run so I completely missed that it was here. Removed.
	12 TEST(ThreadTaskRunnerHandleTest, NullRunner) {

	13 EXPECT_FALSE(ThreadTaskRunnerHandle::IsSet());

	14 EXPECT_EQ(nullptr, ThreadTaskRunnerHandle::Get());

	15 scoped_refptr<TestSimpleTaskRunner> task_runner(new TestSimpleTaskRunner);

	16 ThreadTaskRunnerHandle handle(task_runner);

	17 EXPECT_TRUE(ThreadTaskRunnerHandle::IsSet());

	18 EXPECT_EQ(task_runner, ThreadTaskRunnerHandle::Get());

	19 }

	20

	21 } // namespace base

OLD	NEW